New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass console object in to broccoli-babel-transpiler. #86

Merged
merged 1 commit into from Aug 11, 2016

Conversation

Projects
None yet
3 participants
@rwjblue
Copy link
Member

rwjblue commented Aug 11, 2016

This will be used by broccoli-babel-transpiler to log warnings/deprecations to the console when a given plugin does not provide the correct caching information.

This will be used by babel/broccoli-babel-transpiler#89.

@stefanpenner

This comment has been minimized.

Copy link
Member

stefanpenner commented Aug 11, 2016

sg, in future versions of CLI we may want to have ui.toConsole() or something

@rwjblue

This comment has been minimized.

Copy link
Member Author

rwjblue commented Aug 11, 2016

Ya, that seems like a good idea.

@stefanpenner

This comment has been minimized.

Copy link
Member

stefanpenner commented Aug 11, 2016

for the future.

@rwjblue

This comment has been minimized.

Copy link
Member Author

rwjblue commented Aug 11, 2016

Build is failing because currently there is no way to distinguish options intended to be passed into babel itself, versus those intended for broccoli-babel-transpiler and when babel gets the console object passed here it throws an error.

Ideally, we should refactor the babel options to be passed in via options.babel or something, so that the other non-babel options (like console, includePolyfill, etc) can be in the root of options.

@rwjblue

This comment has been minimized.

Copy link
Member Author

rwjblue commented Aug 11, 2016

I guess I have to release broccoli-babel-transpiler first, then this...

@rwjblue rwjblue force-pushed the rwjblue:pass-console branch from 1fb3baa to d51abd4 Aug 11, 2016

@rwjblue

This comment has been minimized.

Copy link
Member Author

rwjblue commented Aug 11, 2016

Released broccoli-babel-transpiler@5.6.0 and rebased this to update to that version.

Robert Jackson
Pass console object in to broccoli-babel-transpiler.
This will be used by broccoli-babel-transpiler to log
warnings/deprecations to the console when a given plugin does not
provide the correct caching information.
@rwjblue

This comment has been minimized.

Copy link
Member Author

rwjblue commented Aug 11, 2016

@stefanpenner / @Turbo87 - This is ready to go, but I don't have merge + release access here. If one of y'all could release (or add me) I would appreciate it...

@stefanpenner stefanpenner merged commit 0fdada6 into babel:master Aug 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stefanpenner

This comment has been minimized.

Copy link
Member

stefanpenner commented Aug 11, 2016

releasing as v5.1.8

@Turbo87 Turbo87 added the enhancement label Dec 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment