Drop style rules #22
Merged
Drop style rules #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why we are dropping: |
|
Can keep them, but they seem redundant if we're committed to using prettier as it'd handle formatting them? |
|
Oh, I understand, thanks! I just thought about projects using babel-config, but not using prettier. |
|
We could also extend https://github.com/prettier/eslint-config-prettier ? |
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
* Drop style rules * es tweaks * fix * Update index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
babel/babel-loader#409
babel/babel-preset-env#183
babel/babel#5412
babel/babylon#390
Left
max-len@ 110 for babel/babel#5412 (comment)