Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

Deprecate babel/quotes since it's fixed in ESLint 5 #154

Closed
edmorley opened this issue Aug 27, 2018 · 1 comment
Closed

Deprecate babel/quotes since it's fixed in ESLint 5 #154

edmorley opened this issue Aug 27, 2018 · 1 comment

Comments

@edmorley
Copy link

Hi!

The babel/quotes rule references the upstream ESLint issue that it is meant to fix, here:

// Workaround for JSX fragment syntax until
// https://github.com/eslint/eslint/issues/9662
if (problem.node.parent.type === "JSXFragment") {
return false;
}

Looking at eslint/eslint#9662, it has been fixed by eslint/eslint#9664, which is included in ESLint 5.0.

As such, I believe the babel/quotes rule can now be deprecated.

edmorley added a commit to neutrinojs/neutrino that referenced this issue Aug 29, 2018
Since as of ESLint 5 the stock `quotes` rule now includes the fix
for JS fragment quotes, making `babel/quotes` redundant:
babel/eslint-plugin-babel#154
@kaicataldo
Copy link
Member

Thank you for the issue. Now that @babel/eslint-plugin has been released, we are making this repository read-only. If this is a change you would still like to advocate for, please reopen this in the babel/babel monorepo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants