Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render changelog in the website #1038

Closed
wants to merge 3 commits into from

Conversation

@xtuc
Copy link
Member

xtuc commented Dec 5, 2016

Trying to solve #1037

changelog

TODO

  • Emoji are not supported
  • Codeblocks are broken
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Dec 5, 2016

yeah fixes would probably have to go in CHANGELOG.md itself

@xtuc xtuc added the do-not-merge label Dec 6, 2016
@xtuc

This comment has been minimized.

Copy link
Member Author

xtuc commented Dec 6, 2016

Since we want to include the README in babel/babel, I think it's not a good idea to store picture in inside the repo.

We could maybe use a script to replace it dynamically on the website ?

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Dec 6, 2016

what do you mean by pictures? emoji should render correctly on the readme as well

oh if you mean actual pictures we could remove them depending on what we did

@xtuc

This comment has been minimized.

Copy link
Member Author

xtuc commented Dec 6, 2016

I meant replacing the emoji by actual pictures. So this could be displayed on both website and github (and others). But since we should store them in babel/babel, this is not a good idea.

I suggest replacing them using JavaScript on the client-side on the website.

@xtuc xtuc referenced this pull request Dec 6, 2016
@xtuc

This comment has been minimized.

Copy link
Member Author

xtuc commented Dec 11, 2016

Since #1074 we can use emoji on the website.
I guess the CHANGELOG is generated, I'm not sure how to fix the code blocks.

/cc @existentialism

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Dec 11, 2016

Change log isn't generated - it's first generated and then I modify it so we can make changes

@xtuc

This comment has been minimized.

Copy link
Member Author

xtuc commented Dec 13, 2016

changelog

Code blocks are not broken.

@@ -0,0 +1,7 @@
---
layout: docs
title: CHANGELOG

This comment has been minimized.

Copy link
@existentialism

existentialism Dec 13, 2016

Member

Should this be all caps?

This comment has been minimized.

Copy link
@hzoo

hzoo Dec 13, 2016

Member

We can just do Changelog

@existentialism

This comment has been minimized.

Copy link
Member

existentialism commented Dec 13, 2016

Some code blocks are:

image

@existentialism

This comment has been minimized.

Copy link
Member

existentialism commented Dec 13, 2016

We might have to re-visit the sidebar generation code again since it looks like scrollSpy/sidebar is broken on this page

@xtuc

This comment has been minimized.

Copy link
Member Author

xtuc commented Dec 13, 2016

I tried to add a scrollbar to the sidebar. This is not working well... I guess we will need to create a separate issue for this.

scrollbar-changelog

@xtuc

This comment has been minimized.

Copy link
Member Author

xtuc commented Dec 14, 2016

@existentialism Ok for merging this first ?

@xtuc xtuc removed the do-not-merge label Dec 14, 2016
@existentialism

This comment has been minimized.

Copy link
Member

existentialism commented Dec 14, 2016

Should we fix the code blocks that aren't working (likely need newlines) first?

image

@existentialism

This comment has been minimized.

Copy link
Member

existentialism commented Dec 14, 2016

Also the CHANGELOG - 6to5 and Edit this Page links are broken

@stale stale bot added the stale label Jun 12, 2017
@stale

This comment has been minimized.

Copy link

stale bot commented Jun 12, 2017

This issue has been automatically marked as stale because it has not had recent activity 😴. It will be closed if no further activity occurs. Thank you for your contributions 👌!

@stale stale bot closed this Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.