Update repl to Babel 7 #1915
Merged
Update repl to Babel 7 #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove separate handling of Babel and preset-env version, since they are both 7 now - Remove code for the "debug" option, which was already disabled for v7
|
Deploy preview for babel ready! Built with commit f9d729b |
hzoo
reviewed
Dec 12, 2018
| @@ -109,7 +109,7 @@ function compileCode(sourceEditor, targetEditor) { | |||
|
|
|||
| try { | |||
| transformed = Babel.transform(sourceEditor.getValue(), { | |||
| presets: ["latest"], | |||
| presets: ["es2015", "es2016", "es2017"], | |||
There was a problem hiding this comment.
we should would want to get preset-env to be default eventually right?
There was a problem hiding this comment.
I didn't want to load two different bundles just for the minirepl.
I think that, since it is just a demo, it is ok like this?
There was a problem hiding this comment.
totally didn't see it was the minirepl, makes sense!
hzoo
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
they are both 7 now
for v7
(Hide whitespace changes when reviewing)
Fixes #1901