New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Discourse on doc pages. #875

Merged
merged 1 commit into from Nov 8, 2016

Conversation

Projects
None yet
2 participants
@STRML
Collaborator

STRML commented Jul 28, 2016

This is related to #802 - same idea but reuses the Discourse Site.

Unfortunately I can't test this locally - localhost needs to be an embeddable host. We'd also have to add babeljs.io as a host.

It would take minimal work to integrate with the existing discourse server. If nobody is willing to take the time I can do so if credentials are provided - please email if so.

Integration Instructions

@STRML

This comment has been minimized.

Show comment
Hide comment
@STRML

STRML Sep 11, 2016

Collaborator

@hzoo Would you or anyone else be willing to review this please? I've been trying to get comments on babel.github.io in since April - I believe it'd really be a boon to the usability of the documentation.

Collaborator

STRML commented Sep 11, 2016

@hzoo Would you or anyone else be willing to review this please? I've been trying to get comments on babel.github.io in since April - I believe it'd really be a boon to the usability of the documentation.

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Sep 12, 2016

Member

I don't think i'm admin on discourse so can't try/test it either - cc @thejameskyle?

Member

hzoo commented Sep 12, 2016

I don't think i'm admin on discourse so can't try/test it either - cc @thejameskyle?

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Nov 8, 2016

Member

Not sure about how you test it locally, will try it out on the site

Member

hzoo commented Nov 8, 2016

Not sure about how you test it locally, will try it out on the site

@STRML

This comment has been minimized.

Show comment
Hide comment
@STRML

STRML Nov 8, 2016

Collaborator

You could just run the repo, as in npm start?

Would just have to screw with the hostname.

Collaborator

STRML commented Nov 8, 2016

You could just run the repo, as in npm start?

Would just have to screw with the hostname.

@hzoo hzoo merged commit 9864339 into babel:master Nov 8, 2016

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Nov 8, 2016

Member

Got a same origin issue locally too:

  • on babeljs.io

screen shot 2016-11-08 at 4 14 35 pm

Member

hzoo commented Nov 8, 2016

Got a same origin issue locally too:

  • on babeljs.io

screen shot 2016-11-08 at 4 14 35 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment