Adapt left-over Python 2 code #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi. many thanks for the PR. can you please do a PR into dev branch. the master is the stable branch which people install from and hence the request to change dev and then bundle all changes into master once tested |
|
I have updated the dev branch with your PR - will check the dev branch soon and bundle with other changes into master when ready for release. Thanks |
|
You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330 although I know this would just be an intermediate solution if you still plan to implement the necessary bits in Vala to get rid of the Python code. But these minor changes would allow the installation on any Debian or Ubuntu based distribution in the meanwhile (cf. flathub/com.github.babluboy.bookworm#15 for instance).