Upgrading cygwin behind proxy #273

Closed
igitur opened this Issue Apr 7, 2015 · 27 comments

Comments

Projects
None yet
4 participants
@igitur
Contributor

igitur commented Apr 7, 2015

Hi,

I'm also having issues upgrading to the lastest version. I think babun itself upgraded successfully to 1.1.0, but cygwin can't upgrade.

I'm using cntlm as a local proxy which forwards requests to out corporate proxy.

See screenshot.

image

@tombujok

This comment has been minimized.

Show comment
Hide comment
@tombujok

tombujok Apr 7, 2015

Contributor

Yes, you are right, there's been problems with the Internet Connection.

The update.bat has been invoked with the following proxy setup:
update.bat /proxy=http://127.0.0.1:3128
is that correct?

To finish the update try invoking update.bat manually with the correct proxy switch.

Contributor

tombujok commented Apr 7, 2015

Yes, you are right, there's been problems with the Internet Connection.

The update.bat has been invoked with the following proxy setup:
update.bat /proxy=http://127.0.0.1:3128
is that correct?

To finish the update try invoking update.bat manually with the correct proxy switch.

@igitur

This comment has been minimized.

Show comment
Hide comment
@igitur

igitur Apr 7, 2015

Contributor

I tried that command, but it still doesn't work. Here is my full log:

2015/04/07 12:08:48 Starting cygwin install, version 2.870
2015/04/07 12:08:48 User has backup/restore rights
2015/04/07 12:08:48 io_stream_cygfile: fopen(/etc/setup/setup.rc) failed 2 No such file or directory
2015/04/07 12:08:48 Current Directory: C:/Users/FrancoisBo/.babun//dist
2015/04/07 12:08:48 Could not open service McShield for query, start and stop. McAfee may not be installed, or we don't have access.
2015/04/07 12:08:48 root: C:/Users/FrancoisBo/.babun/\cygwin system
2015/04/07 12:08:48 Selected local directory: C:/Users/FrancoisBo/.babun//dist
2015/04/07 12:08:48 net: Proxy
Cached mirror list unavailable
get_url_to_membuf http://cygwin.com/mirrors.lst
getUrlToStream http://cygwin.com/mirrors.lst
getUrlToStream failed!
get_url_to_membuf failed!
Defaulting to empty mirror list
2015/04/07 12:08:48 site: http://mirrors.kernel.org/sourceware/cygwin/
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream failed!
get_url_to_membuf failed!
2015/04/07 12:08:48 mbox note: Unable to get setup.ini from <http://mirrors.kernel.org/sourceware/cygwin/>
2015/04/07 12:08:48 unattended_mode is set at mbox: returning default value
2015/04/07 12:08:48 site: http://mirrors.kernel.org/sourceware/cygwin/
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream failed!
get_url_to_membuf failed!
2015/04/07 12:08:48 mbox note: Unable to get setup.ini from <http://mirrors.kernel.org/sourceware/cygwin/>
2015/04/07 12:08:48 unattended_mode is set at mbox: returning default value
2015/04/07 12:08:48 site: http://mirrors.kernel.org/sourceware/cygwin/
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream failed!
get_url_to_membuf failed!
2015/04/07 12:08:48 mbox note: Unable to get setup.ini from <http://mirrors.kernel.org/sourceware/cygwin/>
2015/04/07 12:08:48 unattended_mode is set at mbox: returning default value
2015/04/07 12:08:48 site: http://mirrors.kernel.org/sourceware/cygwin/
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream failed!
get_url_to_membuf failed!
2015/04/07 12:08:48 mbox note: Unable to get setup.ini from <http://mirrors.kernel.org/sourceware/cygwin/>
2015/04/07 12:08:48 unattended_mode is set at mbox: returning default value
2015/04/07 12:08:48 site: http://mirrors.kernel.org/sourceware/cygwin/
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream failed!
get_url_to_membuf failed!
2015/04/07 12:08:48 mbox note: Unable to get setup.ini from <http://mirrors.kernel.org/sourceware/cygwin/>
2015/04/07 12:08:48 unattended_mode is set at mbox: returning default value
2015/04/07 12:08:48 download/verify error in unattended_mode: out of retries
2015/04/07 12:08:48 note: Installation incomplete.  Check C:\Users\FrancoisBo\.babun\\cygwin\var\log\setup.log.full for details
2015/04/07 12:08:48 Ending cygwin install
Contributor

igitur commented Apr 7, 2015

I tried that command, but it still doesn't work. Here is my full log:

2015/04/07 12:08:48 Starting cygwin install, version 2.870
2015/04/07 12:08:48 User has backup/restore rights
2015/04/07 12:08:48 io_stream_cygfile: fopen(/etc/setup/setup.rc) failed 2 No such file or directory
2015/04/07 12:08:48 Current Directory: C:/Users/FrancoisBo/.babun//dist
2015/04/07 12:08:48 Could not open service McShield for query, start and stop. McAfee may not be installed, or we don't have access.
2015/04/07 12:08:48 root: C:/Users/FrancoisBo/.babun/\cygwin system
2015/04/07 12:08:48 Selected local directory: C:/Users/FrancoisBo/.babun//dist
2015/04/07 12:08:48 net: Proxy
Cached mirror list unavailable
get_url_to_membuf http://cygwin.com/mirrors.lst
getUrlToStream http://cygwin.com/mirrors.lst
getUrlToStream failed!
get_url_to_membuf failed!
Defaulting to empty mirror list
2015/04/07 12:08:48 site: http://mirrors.kernel.org/sourceware/cygwin/
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream failed!
get_url_to_membuf failed!
2015/04/07 12:08:48 mbox note: Unable to get setup.ini from <http://mirrors.kernel.org/sourceware/cygwin/>
2015/04/07 12:08:48 unattended_mode is set at mbox: returning default value
2015/04/07 12:08:48 site: http://mirrors.kernel.org/sourceware/cygwin/
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream failed!
get_url_to_membuf failed!
2015/04/07 12:08:48 mbox note: Unable to get setup.ini from <http://mirrors.kernel.org/sourceware/cygwin/>
2015/04/07 12:08:48 unattended_mode is set at mbox: returning default value
2015/04/07 12:08:48 site: http://mirrors.kernel.org/sourceware/cygwin/
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream failed!
get_url_to_membuf failed!
2015/04/07 12:08:48 mbox note: Unable to get setup.ini from <http://mirrors.kernel.org/sourceware/cygwin/>
2015/04/07 12:08:48 unattended_mode is set at mbox: returning default value
2015/04/07 12:08:48 site: http://mirrors.kernel.org/sourceware/cygwin/
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream failed!
get_url_to_membuf failed!
2015/04/07 12:08:48 mbox note: Unable to get setup.ini from <http://mirrors.kernel.org/sourceware/cygwin/>
2015/04/07 12:08:48 unattended_mode is set at mbox: returning default value
2015/04/07 12:08:48 site: http://mirrors.kernel.org/sourceware/cygwin/
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.bz2.sig
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini
getUrlToStream failed!
get_url_to_membuf failed!
get_url_to_membuf http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream http://mirrors.kernel.org/sourceware/cygwin/x86/setup.ini.sig
getUrlToStream failed!
get_url_to_membuf failed!
2015/04/07 12:08:48 mbox note: Unable to get setup.ini from <http://mirrors.kernel.org/sourceware/cygwin/>
2015/04/07 12:08:48 unattended_mode is set at mbox: returning default value
2015/04/07 12:08:48 download/verify error in unattended_mode: out of retries
2015/04/07 12:08:48 note: Installation incomplete.  Check C:\Users\FrancoisBo\.babun\\cygwin\var\log\setup.log.full for details
2015/04/07 12:08:48 Ending cygwin install
@tombujok

This comment has been minimized.

Show comment
Hide comment
@tombujok

tombujok Apr 7, 2015

Contributor

I mean you have to figure out what is the correct address of your proxy.
You can also try without proxy.
Update.bat runs the cygwin setup.exe so ther's no bug there. The problem
with your update is the correct proxy setup.

On Tue, Apr 7, 2015 at 12:10 PM, Francois Botha notifications@github.com
wrote:

I tried that command, but it still doesn't work.


Reply to this email directly or view it on GitHub
#273 (comment).

Contributor

tombujok commented Apr 7, 2015

I mean you have to figure out what is the correct address of your proxy.
You can also try without proxy.
Update.bat runs the cygwin setup.exe so ther's no bug there. The problem
with your update is the correct proxy setup.

On Tue, Apr 7, 2015 at 12:10 PM, Francois Botha notifications@github.com
wrote:

I tried that command, but it still doesn't work.


Reply to this email directly or view it on GitHub
#273 (comment).

@igitur

This comment has been minimized.

Show comment
Hide comment
@igitur

igitur Apr 7, 2015

Contributor

That is the correct proxy. It's a local cntlm proxy. http://cntlm.sourceforge.net

My oh-my-zsh scripts update through it all the time.

I'm starting to think this is a cygwin bug, not a babun bug.

Contributor

igitur commented Apr 7, 2015

That is the correct proxy. It's a local cntlm proxy. http://cntlm.sourceforge.net

My oh-my-zsh scripts update through it all the time.

I'm starting to think this is a cygwin bug, not a babun bug.

@tombujok

This comment has been minimized.

Show comment
Hide comment
@tombujok

tombujok Apr 7, 2015

Contributor

I understand, so 127.0.0.1:3128 is the correct address.
Could you try directly with your corporate proxy?

Contributor

tombujok commented Apr 7, 2015

I understand, so 127.0.0.1:3128 is the correct address.
Could you try directly with your corporate proxy?

@igitur

This comment has been minimized.

Show comment
Hide comment
@igitur

igitur Apr 7, 2015

Contributor

Ah, found the problem. The setup-x86.exe file expects the proxy parameter in this format:
--proxy=127.0.0.1:3128

Currently it is being sent through as
--proxy=http://127.0.0.1:3128

The http or https should be stripped from the entry in the environment variable.

Contributor

igitur commented Apr 7, 2015

Ah, found the problem. The setup-x86.exe file expects the proxy parameter in this format:
--proxy=127.0.0.1:3128

Currently it is being sent through as
--proxy=http://127.0.0.1:3128

The http or https should be stripped from the entry in the environment variable.

@tombujok

This comment has been minimized.

Show comment
Hide comment
@tombujok

tombujok Apr 7, 2015

Contributor

Great that it works!

It's funny because it works for me with the http(s) prefix, but maybe cntlm
proxy is kind of an edge case...?

On Tue, Apr 7, 2015 at 12:50 PM, Francois Botha notifications@github.com
wrote:

Ah, found the problem. The setup-x86.exe file expects the proxy parameter
in this format:
--proxy=127.0.0.1:3128

Currently it is being sent through as
--proxy=http://127.0.0.1:3128

The http or https should be stripped from the entry in the environment
variable.


Reply to this email directly or view it on GitHub
#273 (comment).

Contributor

tombujok commented Apr 7, 2015

Great that it works!

It's funny because it works for me with the http(s) prefix, but maybe cntlm
proxy is kind of an edge case...?

On Tue, Apr 7, 2015 at 12:50 PM, Francois Botha notifications@github.com
wrote:

Ah, found the problem. The setup-x86.exe file expects the proxy parameter
in this format:
--proxy=127.0.0.1:3128

Currently it is being sent through as
--proxy=http://127.0.0.1:3128

The http or https should be stripped from the entry in the environment
variable.


Reply to this email directly or view it on GitHub
#273 (comment).

@igitur

This comment has been minimized.

Show comment
Hide comment
@igitur

igitur Apr 7, 2015

Contributor

No, I also tried with the corporate proxy and it failed. You have to omit the http:// part.

Contributor

igitur commented Apr 7, 2015

No, I also tried with the corporate proxy and it failed. You have to omit the http:// part.

@igitur

This comment has been minimized.

Show comment
Hide comment
@igitur

igitur Apr 7, 2015

Contributor

Oh, but you say it worked for you. Weird. When I run setup-x86.exe --help it does state that the proxy format is:

-p --proxy HTTP/FTP proxy (host:port)

Contributor

igitur commented Apr 7, 2015

Oh, but you say it worked for you. Weird. When I run setup-x86.exe --help it does state that the proxy format is:

-p --proxy HTTP/FTP proxy (host:port)

@tombujok

This comment has been minimized.

Show comment
Hide comment
@tombujok

tombujok Apr 7, 2015

Contributor

You are right, it strips the http:// part correctly when the http proxy is specified like this:
http_proxy=http://user:pass@host:port

It does NOT work if there's no user:pass
http_proxy=http://host:port

This is the command that extract the proxy in the update process:
/bin/grep.exe 'export http_proxy=' ~/.babunrc | /bin/grep.exe -v '#' | /bin/sed.exe 's/export http_proxy=//g' | /bin/cut.exe -d "@" -f 2

Could anyone fix it so that it works correctly in both cases?

Contributor

tombujok commented Apr 7, 2015

You are right, it strips the http:// part correctly when the http proxy is specified like this:
http_proxy=http://user:pass@host:port

It does NOT work if there's no user:pass
http_proxy=http://host:port

This is the command that extract the proxy in the update process:
/bin/grep.exe 'export http_proxy=' ~/.babunrc | /bin/grep.exe -v '#' | /bin/sed.exe 's/export http_proxy=//g' | /bin/cut.exe -d "@" -f 2

Could anyone fix it so that it works correctly in both cases?

@darinkes

This comment has been minimized.

Show comment
Hide comment
@darinkes

darinkes Apr 7, 2015

Contributor

Hehe, had the same problem today.

Here's my approach to fix this:

{ ~ }  » echo "export http_proxy=http://user:pass@host:port" | /bin/sed.exe 's,export http_proxy=http://,,g' | /bin/awk '{n=split($0,a,"@"); print a[n]}'
host:port
{ ~ }  » echo "export http_proxy=http://host:port" | /bin/sed.exe 's,export http_proxy=http://,,g' | /bin/awk '{n=split($0,a,"@"); print a[n]}'
host:port
Contributor

darinkes commented Apr 7, 2015

Hehe, had the same problem today.

Here's my approach to fix this:

{ ~ }  » echo "export http_proxy=http://user:pass@host:port" | /bin/sed.exe 's,export http_proxy=http://,,g' | /bin/awk '{n=split($0,a,"@"); print a[n]}'
host:port
{ ~ }  » echo "export http_proxy=http://host:port" | /bin/sed.exe 's,export http_proxy=http://,,g' | /bin/awk '{n=split($0,a,"@"); print a[n]}'
host:port
@tombujok

This comment has been minimized.

Show comment
Hide comment
@tombujok

tombujok Apr 7, 2015

Contributor

Thx!
So the correct command that should be placed in update.bat looks like this IMHO:
source ~/.babunrc && echo $http_proxy | /bin/sed.exe 's,http://,,g' | /bin/awk '{n=split($0,a,"@"); print a[n]}'

any objections?

Contributor

tombujok commented Apr 7, 2015

Thx!
So the correct command that should be placed in update.bat looks like this IMHO:
source ~/.babunrc && echo $http_proxy | /bin/sed.exe 's,http://,,g' | /bin/awk '{n=split($0,a,"@"); print a[n]}'

any objections?

@darinkes

This comment has been minimized.

Show comment
Hide comment
@darinkes

darinkes Apr 7, 2015

Contributor

👍 looks good

Contributor

darinkes commented Apr 7, 2015

👍 looks good

@jlupi

This comment has been minimized.

Show comment
Hide comment
@jlupi

jlupi Apr 7, 2015

Contributor

it works, just for the consistency use /bin/awk.exe

Contributor

jlupi commented Apr 7, 2015

it works, just for the consistency use /bin/awk.exe

@darinkes

This comment has been minimized.

Show comment
Hide comment
@darinkes

darinkes Apr 7, 2015

Contributor

{ ~ } » /bin/awk.exe
-bash: /bin/awk.exe: No such file or directory

Contributor

darinkes commented Apr 7, 2015

{ ~ } » /bin/awk.exe
-bash: /bin/awk.exe: No such file or directory

@tombujok

This comment has been minimized.

Show comment
Hide comment
@tombujok

tombujok Apr 7, 2015

Contributor

there's /bin/gawk.exe, we could use this one.

{ code } master » ls -al /bin/awk
lrwxrwxrwx 1 ue62407 8 Jun 6 2014 /bin/awk -> gawk.exe

On Tue, Apr 7, 2015 at 2:08 PM, Stefan Rinkes notifications@github.com
wrote:

{ ~ } » /bin/awk.exe
-bash: /bin/awk.exe: No such file or directory


Reply to this email directly or view it on GitHub
#273 (comment).

Contributor

tombujok commented Apr 7, 2015

there's /bin/gawk.exe, we could use this one.

{ code } master » ls -al /bin/awk
lrwxrwxrwx 1 ue62407 8 Jun 6 2014 /bin/awk -> gawk.exe

On Tue, Apr 7, 2015 at 2:08 PM, Stefan Rinkes notifications@github.com
wrote:

{ ~ } » /bin/awk.exe
-bash: /bin/awk.exe: No such file or directory


Reply to this email directly or view it on GitHub
#273 (comment).

@tombujok

This comment has been minimized.

Show comment
Hide comment
@tombujok

tombujok Apr 7, 2015

Contributor

@darinkes Do you want to submit a PR, so that the commit is on your account ;) ?

Contributor

tombujok commented Apr 7, 2015

@darinkes Do you want to submit a PR, so that the commit is on your account ;) ?

darinkes added a commit to darinkes/babun that referenced this issue Apr 7, 2015

Fixes parsing of http_proxy for update.bat
Improve parsing of the http_proxy env to work with user:pass@host:port
and host:port.

Fixes #273
@darinkes

This comment has been minimized.

Show comment
Hide comment
@darinkes

darinkes Apr 7, 2015

Contributor

Sure! Here you go :)
Just tested it by updating to current release.

Contributor

darinkes commented Apr 7, 2015

Sure! Here you go :)
Just tested it by updating to current release.

@darinkes

This comment has been minimized.

Show comment
Hide comment
@darinkes

darinkes Apr 7, 2015

Contributor

wait with merging, a minor syntax problem occured.

Contributor

darinkes commented Apr 7, 2015

wait with merging, a minor syntax problem occured.

@tombujok

This comment has been minimized.

Show comment
Hide comment
@tombujok

tombujok Apr 7, 2015

Contributor

OK, and plz make sure that it returns nothing (but does not fail) when the
.babunrc file does not exist

On Tue, Apr 7, 2015 at 2:25 PM, Stefan Rinkes notifications@github.com
wrote:

wait with merging, a minor syntax problem occured.


Reply to this email directly or view it on GitHub
#273 (comment).

Contributor

tombujok commented Apr 7, 2015

OK, and plz make sure that it returns nothing (but does not fail) when the
.babunrc file does not exist

On Tue, Apr 7, 2015 at 2:25 PM, Stefan Rinkes notifications@github.com
wrote:

wait with merging, a minor syntax problem occured.


Reply to this email directly or view it on GitHub
#273 (comment).

darinkes added a commit to darinkes/babun that referenced this issue Apr 7, 2015

Fixes parsing of http_proxy for update.bat
Improve parsing of the http_proxy env to work with user:pass@host:port
and host:port.

Fixes #273
@darinkes

This comment has been minimized.

Show comment
Hide comment
@darinkes

darinkes Apr 7, 2015

Contributor

Ok. Done.
Escaping is a total pain in the a**

Contributor

darinkes commented Apr 7, 2015

Ok. Done.
Escaping is a total pain in the a**

@jlupi

This comment has been minimized.

Show comment
Hide comment
@jlupi

jlupi Apr 7, 2015

Contributor

@darinkes @tombujok looks cool, but I gues it fails if the .babunrc file does not exist. For me greping .babunrc instead of sourceing it is a safer option. Otherwise we have to add additional check here. WDYT?

Contributor

jlupi commented Apr 7, 2015

@darinkes @tombujok looks cool, but I gues it fails if the .babunrc file does not exist. For me greping .babunrc instead of sourceing it is a safer option. Otherwise we have to add additional check here. WDYT?

@jlupi

This comment has been minimized.

Show comment
Hide comment
@jlupi

jlupi Apr 7, 2015

Contributor

sorry just tried it, it will be the same thing, grep also complains if the file does not exist.

Contributor

jlupi commented Apr 7, 2015

sorry just tried it, it will be the same thing, grep also complains if the file does not exist.

@tombujok

This comment has been minimized.

Show comment
Hide comment
@tombujok

tombujok Apr 7, 2015

Contributor

Could you guys retest when the file does not exist?
@jlupi I think echo is still safer. A person can have sth like this:

export proxy=proxy.com:8080
export http_proxy=$proxy
export https_proxy=$proxy
export ftp_proxy=$proxy

In this case echo is much better, otherwise it's the same IMHO.

Contributor

tombujok commented Apr 7, 2015

Could you guys retest when the file does not exist?
@jlupi I think echo is still safer. A person can have sth like this:

export proxy=proxy.com:8080
export http_proxy=$proxy
export https_proxy=$proxy
export ftp_proxy=$proxy

In this case echo is much better, otherwise it's the same IMHO.

@darinkes

This comment has been minimized.

Show comment
Hide comment
@darinkes

darinkes Apr 7, 2015

Contributor

I don't think it's a problem in this case, cause update.bat tries to source .babunrc multiple times before checking for the proxy.

See SETUPRC and RUNNINGCHECK

Contributor

darinkes commented Apr 7, 2015

I don't think it's a problem in this case, cause update.bat tries to source .babunrc multiple times before checking for the proxy.

See SETUPRC and RUNNINGCHECK

@tombujok

This comment has been minimized.

Show comment
Hide comment
@tombujok

tombujok Apr 7, 2015

Contributor

I've just tested it and it works fine with and without .babunrc file.
We will publish a fix release whenever we will find a free slot of time...

Contributor

tombujok commented Apr 7, 2015

I've just tested it and it works fine with and without .babunrc file.
We will publish a fix release whenever we will find a free slot of time...

@tombujok tombujok closed this in #274 Apr 7, 2015

@tombujok

This comment has been minimized.

Show comment
Hide comment
@tombujok

tombujok Apr 7, 2015

Contributor

1.1.1 with the proxy fix released

Contributor

tombujok commented Apr 7, 2015

1.1.1 with the proxy fix released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment