New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update format customizations handling #332
Conversation
Not sure why this is so damn finicky!
I'm pretty confident in this approach so I'll move it forward (want to move a 1.9.1 release but not with the en-GB unhappiness). Will address any issues in further tickets. |
@cdubz Apologies, I didn't get a chance to have a look the other day. I'm not familiar enough with Python/Django to make any strong comments regarding implementation; I mainly using c#. For my understanding, would the overrides follow the same partern here, requiring a I'll open a new issue to address the 24h format for |
No worries! I'm just antsy for a release (: So yeah for customizing a particular locale you could pretty much follow exactly what was done for " |
Yeah, odd they don't seem to follow the 'modern' standard, 12h is more common in spoken communication (this would be said as 'three in the morning/afternoon' rather than 'AM/PM'), but not for written communication, especially when formal or digital. I'll see you over at #333 so I don't get confused :) |
@Amith211 馃憢 -- I'd appreciate your feedback on this branch. This moves the format handling to middleware because there seems to be no agreeable way to make this work with format modules.
Re: the 12h vs. 24h display -- Django's default formats for
en-GB
actually use 12h format. TheUSE_24_HOUR_TIME_FORMAT
setting needs to be implemented per-locale when overriding the defaults. Do you think that should be necessary here? I'm not sure what the standard is in the UK but I'd be surprised if Django's defaults are not the norm.Fixes #324.