Skip to content

Misc improvements #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 14, 2025
Merged

Misc improvements #16

merged 7 commits into from
Jan 14, 2025

Conversation

@kirugan
Copy link
Contributor

@kirugan kirugan commented Jan 14, 2025

  1. Call context cancelFunc explicitly within the loop
  2. Change receiver in IncrementRetryAttempts (pointer instead of struct copy)

gusin13
gusin13 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@gusin13 gusin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@kirugan kirugan merged commit 994012e into main Jan 14, 2025
1 check passed
@jrwbabylonlab jrwbabylonlab deleted the kirugan/misc-improvements branch January 14, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gusin13 gusin13 gusin13 approved these changes

@jrwbabylonlab jrwbabylonlab jrwbabylonlab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kirugan @gusin13 @jrwbabylonlab