From 42857f25332a12e09ddee7758896484eaa245938 Mon Sep 17 00:00:00 2001 From: "sonarqube-agent[bot]" <210722872+sonarqube-agent[bot]@users.noreply.github.com> Date: Fri, 19 Jun 2026 18:04:15 +0000 Subject: [PATCH] fix: Address 5 SonarQube issues Fixed issues: - AZ3eW054PF-XYsB0Knbw for java:S3776 rule - AZ3eW00ZPF-XYsB0KnaW for java:S3776 rule - AZ3eW08FPF-XYsB0Knca for java:S3776 rule - AZ3eW09NPF-XYsB0Kncz for java:S3776 rule - AZ3eW04IPF-XYsB0KnbW for java:S3776 rule Generated by SonarQube Agent (task: fc5c8900-fe9f-4ce9-a928-899598b297f8) --- .../testcode/BenchmarkTest01197.java | 29 ++++++++------- .../testcode/BenchmarkTest01399.java | 33 +++++++++-------- .../testcode/BenchmarkTest02295.java | 37 +++++++++++-------- .../testcode/BenchmarkTest02360.java | 37 +++++++++++-------- .../testcode/BenchmarkTest02614.java | 29 ++++++++------- 5 files changed, 91 insertions(+), 74 deletions(-) diff --git a/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest01197.java b/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest01197.java index ac1e5a8d24..4ea46bc971 100644 --- a/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest01197.java +++ b/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest01197.java @@ -72,19 +72,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) String cookieName = "rememberMe" + testCaseNumber; - boolean foundUser = false; - javax.servlet.http.Cookie[] cookies = request.getCookies(); - if (cookies != null) { - for (int i = 0; !foundUser && i < cookies.length; i++) { - javax.servlet.http.Cookie cookie = cookies[i]; - if (cookieName.equals(cookie.getName())) { - if (cookie.getValue() - .equals(request.getSession().getAttribute(cookieName))) { - foundUser = true; - } - } - } - } + boolean foundUser = isUserFound(request, cookieName); if (foundUser) { response.getWriter().println("Welcome back: " + user + "
"); @@ -116,6 +104,21 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) } } // end doPost + private boolean isUserFound(HttpServletRequest request, String cookieName) { + javax.servlet.http.Cookie[] cookies = request.getCookies(); + if (cookies != null) { + for (int i = 0; i < cookies.length; i++) { + javax.servlet.http.Cookie cookie = cookies[i]; + if (cookieName.equals(cookie.getName()) + && cookie.getValue() + .equals(request.getSession().getAttribute(cookieName))) { + return true; + } + } + } + return false; + } + private class Test { public String doSomething(HttpServletRequest request, String param) diff --git a/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest01399.java b/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest01399.java index 4a31a78610..98958e2fdb 100644 --- a/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest01399.java +++ b/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest01399.java @@ -40,22 +40,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { response.setContentType("text/html;charset=UTF-8"); - String param = ""; - boolean flag = true; - java.util.Enumeration names = request.getParameterNames(); - while (names.hasMoreElements() && flag) { - String name = (String) names.nextElement(); - String[] values = request.getParameterValues(name); - if (values != null) { - for (int i = 0; i < values.length && flag; i++) { - String value = values[i]; - if (value.equals("BenchmarkTest01399")) { - param = name; - flag = false; - } - } - } - } + String param = extractParam(request); String bar = new Test().doSomething(request, param); @@ -120,6 +105,22 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) "Crypto Test javax.crypto.Cipher.getInstance(java.lang.String,java.lang.String) executed"); } // end doPost + private static String extractParam(HttpServletRequest request) { + java.util.Enumeration names = request.getParameterNames(); + while (names.hasMoreElements()) { + String name = (String) names.nextElement(); + String[] values = request.getParameterValues(name); + if (values != null) { + for (int i = 0; i < values.length; i++) { + if (values[i].equals("BenchmarkTest01399")) { + return name; + } + } + } + } + return ""; + } + private class Test { public String doSomething(HttpServletRequest request, String param) diff --git a/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02295.java b/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02295.java index 142d9c5856..6d7e30b78e 100644 --- a/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02295.java +++ b/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02295.java @@ -40,22 +40,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { response.setContentType("text/html;charset=UTF-8"); - String param = ""; - boolean flag = true; - java.util.Enumeration names = request.getParameterNames(); - while (names.hasMoreElements() && flag) { - String name = (String) names.nextElement(); - String[] values = request.getParameterValues(name); - if (values != null) { - for (int i = 0; i < values.length && flag; i++) { - String value = values[i]; - if (value.equals("BenchmarkTest02295")) { - param = name; - flag = false; - } - } - } - } + String param = extractParam(request); String bar = doSomething(request, param); @@ -130,6 +115,26 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) } } // end doPost + private static String extractParam(HttpServletRequest request) { + String param = ""; + boolean flag = true; + java.util.Enumeration names = request.getParameterNames(); + while (names.hasMoreElements() && flag) { + String name = (String) names.nextElement(); + String[] values = request.getParameterValues(name); + if (values != null) { + for (int i = 0; i < values.length && flag; i++) { + String value = values[i]; + if (value.equals("BenchmarkTest02295")) { + param = name; + flag = false; + } + } + } + } + return param; + } + private static String doSomething(HttpServletRequest request, String param) throws ServletException, IOException { diff --git a/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02360.java b/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02360.java index 7ee083d7e5..4b7b4741b7 100644 --- a/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02360.java +++ b/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02360.java @@ -40,22 +40,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { response.setContentType("text/html;charset=UTF-8"); - String param = ""; - boolean flag = true; - java.util.Enumeration names = request.getParameterNames(); - while (names.hasMoreElements() && flag) { - String name = (String) names.nextElement(); - String[] values = request.getParameterValues(name); - if (values != null) { - for (int i = 0; i < values.length && flag; i++) { - String value = values[i]; - if (value.equals("BenchmarkTest02360")) { - param = name; - flag = false; - } - } - } - } + String param = extractParam(request); String bar = doSomething(request, param); @@ -79,6 +64,26 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) } } // end doPost + private static String extractParam(HttpServletRequest request) { + String param = ""; + boolean flag = true; + java.util.Enumeration names = request.getParameterNames(); + while (names.hasMoreElements() && flag) { + String name = (String) names.nextElement(); + String[] values = request.getParameterValues(name); + if (values != null) { + for (int i = 0; i < values.length && flag; i++) { + String value = values[i]; + if (value.equals("BenchmarkTest02360")) { + param = name; + flag = false; + } + } + } + } + return param; + } + private static String doSomething(HttpServletRequest request, String param) throws ServletException, IOException { diff --git a/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02614.java b/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02614.java index f5161a75de..ccf80894f9 100644 --- a/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02614.java +++ b/src/main/java/org/owasp/benchmark/testcode/BenchmarkTest02614.java @@ -88,19 +88,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) String cookieName = "rememberMe" + testCaseNumber; - boolean foundUser = false; - javax.servlet.http.Cookie[] cookies = request.getCookies(); - if (cookies != null) { - for (int i = 0; !foundUser && i < cookies.length; i++) { - javax.servlet.http.Cookie cookie = cookies[i]; - if (cookieName.equals(cookie.getName())) { - if (cookie.getValue() - .equals(request.getSession().getAttribute(cookieName))) { - foundUser = true; - } - } - } - } + boolean foundUser = findUserCookie(request, cookieName); if (foundUser) { response.getWriter().println("Welcome back: " + user + "
"); @@ -132,6 +120,21 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) } } // end doPost + private static boolean findUserCookie(HttpServletRequest request, String cookieName) { + javax.servlet.http.Cookie[] cookies = request.getCookies(); + if (cookies != null) { + for (int i = 0; i < cookies.length; i++) { + javax.servlet.http.Cookie cookie = cookies[i]; + if (cookieName.equals(cookie.getName()) + && cookie.getValue() + .equals(request.getSession().getAttribute(cookieName))) { + return true; + } + } + } + return false; + } + void getNextNumber(java.util.Random generator, byte[] barray) { generator.nextBytes(barray); }