Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

requestPager will make requests even if you've already reached totalPages #169

Closed
nthsense opened this Issue · 2 comments

3 participants

@nthsense

In the clientPager's nextPage method, there is a check to see if you've already reach the last page or not. requestPager.nextPage should also have this check, to avoid an unnecessary request.

@addyosmani
Owner

Agreed. A patch would be welcome for this if anyone wants to take it on.

@thachhoang

There should also be a check against firstPage in the prevPage method for both pagers.

If we keep calling prevPage() after hitting the first page, the currentPage field will be negative, and we will need to call nextPage() an equal number of times to get back to the first page again. Meanwhile, on the UI, the next page button seems ineffective.

@addyosmani addyosmani closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.