Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Jasmine tests #28

Closed
alexandernst opened this Issue · 11 comments

3 participants

@alexandernst

Jasmine tests should be added in order to check the state of the library.
(I'm creating this just to let others know that I'm working on it)

@skusunam
Owner

@alexandernst How is the testing effort going? I might be able to help on this. Let me know if we can split and write some Jasmine tests?

@alexandernst
Owner

@skusunam Well, I'm still reading about Jasmine and looking at examples, but I think I'll start doing some basic tests tonight. Let me create the base files (basic test.html, etc...) and if you want you can do the rest of the tests.
@addyosmani Showed me an example that will be really helpful: https://github.com/larrymyers/backbone-koans/blob/master/js/koans/aboutCollections.js

@skusunam
Owner

@alexandernst I started using Jasmine for last couple of months along with sinon.js (http://sinonjs.org/). Currently i am writing code using coffeescript \ backbone \ jasmine \ sinon. I am new to these technologies but gained enough knowledge to write jasmine tests to this paginator. I will try to write few tests locally and we can sync up and talk about them.

I am using this paginator in my current project to display list of books on a default landing page with options to navigate to "prev", "next" and also "goto". I have few challenges and hoping to resolve them locally and also see if i can submit them as "pull request". I just went through "Change log" from @addyosmani and noticed i have already done some of them and should have submitted as "pull request" :(

@alexandernst
Owner

Oh, if you have some experience, that's way more than mine ( :p ) so if you want you can write the entire tests yourself ;)
Meanwhile I can do another issue I have in mind...

What features? If you have some suggestions, post them here as requests.

Regards!

@skusunam
Owner

@alexandernst I have added 2 requests. Please take a look at it and i have modified code locally for my use. If those make sense i can put a "pull request". I just forked this repo and will catch up with the latest code and start writing some jasmine tests for "Paginator.requestPager".

@skusunam
Owner

@alexandernst @addyosmani I started working on writing some Jamsine tests to this library. I have a question:

How are we planning to run these Jasmine tests? (Locally i use 'jasmine-maven-plugin' https://github.com/searls/jasmine-maven-plugin and guess it doesn't make sense to use it for this library. May be we can provide 'specrunner.html' like https://github.com/larrymyers/backbone-koans/blob/master/specrunner.html which can be used to run these tests?

Once i have these first round of tests i will put a 'pull request'. Thanks !!!!

@alexandernst
Owner

@skusunam I have really no idea about TDD, so you're better asking @addyosmani I'm sorry not being in any help with this one :(

@addyosmani
Owner

@skusunam Typically I just use a local specrunner for projects like this. I think we can tie any Jasmine tests nicely into the grunt build process once we've hooked everything up so that any changes have to pass through that before we allow them to merge.

Happy to review any initial work on unit tests. Thanks!

@alexandernst

@skusunam Is this still going on?

@skusunam
Owner

@alexandernst #50 will replace this issue. You can close this as #50 is active.

@alexandernst

@skusunam Ok, thank you :)

@wyuenho wyuenho referenced this issue from a commit
@wyuenho wyuenho Fix #20, #21, #22, #23, #25, #26 and #28 2a9246c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.