Able to page in to negative pages #90

Closed
tominated opened this Issue Sep 28, 2012 · 2 comments

Comments

Projects
None yet
2 participants

I've found that if one was to rapidly fire the requestPreviousPage event on a requestPager, it will no stop you from going in to negative pages. I can't use the curentPage attribute as a guard (unless I'm doing something wrong), because the currentPage attribute waits until the request finishes to update.

Any ideas?

Well I have fixed it by keeping track of the page manually, but it does feel kind of hackish, and it seems that it should be built in to the plugin

Owner

addyosmani commented May 18, 2013

I agree that this should be built-in. Would anyone be interested in working on a patch to add this to the plugin?

@wyuenho wyuenho added a commit that referenced this issue May 7, 2014

@wyuenho wyuenho Fix #90 extra query param should not be included in the query string …
…if the value is null
1ff89b7

addyosmani closed this May 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment