Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'XML sitemap' field from 'Manage Fields' page #56

Closed
BWPanda opened this issue Jun 28, 2018 · 7 comments

Comments

@BWPanda
Copy link
Member

commented Jun 28, 2018

On the 'Manage Fields' page (admin/structure/types/manage/[CONTENT_TYPE]/fields) there's a 'field' for 'XML sitemap' which allows reordering but not configuration. This is pointless as the 'XML sitemap' field(s) on node forms are in a vertical tab and cannot be reordered. I suggest removing this for a cleaner UI.

@BWPanda

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2018

Example:

screenshot-2018-6-28 feature packweb

screenshot-2018-6-28 create feature packweb
(the field covered by the admin bar is 'Icon')

@alexfinnarn

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2018

screen shot 2018-07-23 at 3 20 58 pm

Seems like other modules also follow this pattern so site builders might be familiar with seeing this...

It is done in the code here...
https://github.com/backdrop-contrib/xmlsitemap/blob/1.x-1.x/xmlsitemap_node/xmlsitemap_node.module#L154

I'm not sure what removing xmlsitemap_node_field_extra_fields() would do elsewhere in the module, though.

https://api.backdropcms.org/api/backdrop/core%21modules%21field%21field.api.php/function/hook_field_extra_fields/1

Thoughts?

@jenlampton

This comment has been minimized.

Copy link
Member

commented Jan 9, 2019

This is pointless as the 'XML sitemap' field(s) on node forms are in a vertical tab and cannot be reordered.

This setting does control the order of fields within the vertical tabs, as long as there are other orderable psuedo-fields in there to order them against. I often have Paging, Metatag, and XMLsitemap, all which have vertical tabs, and sometimes it's useful to order those.

That said, I'm not sure I'd miss the ordering of any of those vertical tabs if they all were to go.

@alexfinnarn

This comment has been minimized.

Copy link
Contributor

commented Jan 21, 2019

I see what @jenlampton is saying about the ordering. My opinion would be to not change anything here. I can totally see some client saying "I want this field to show up above this other field in the form" and there's no real reason to change the code to make that task harder. Changing the code here would remove configuration without adding any real benefit.

@laryn

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

I was noticing this same thing with Rabbit Hole and was going to try to get rid of it at some point because I find it annoying.

@jenlampton

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

What if core added all the vertical tab options to this ordering form too, but maybe with a visual indicator that shows they would be separate from the other fields? That way it would be clearer when you only had one v-tab option that it wouldn't be ordered against the other non-v-tab options.

@laryn

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Closing this in favor of the core issue opened here:
backdrop/backdrop-issues#4002

@laryn laryn closed this Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.