Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal security release #57

Closed
kreynen opened this issue Jul 18, 2018 · 3 comments
Closed

Drupal security release #57

kreynen opened this issue Jul 18, 2018 · 3 comments

Comments

@kreynen
Copy link
Contributor

kreynen commented Jul 18, 2018

https://www.drupal.org/sa-contrib-2018-053

Need to add make similar changes to https://github.com/CuBoulder/express/pull/2801/files#diff-3bbf127722c1bac6188e594cf607caf2R17 for the same reasons

@alexfinnarn
Copy link
Contributor

Different tests are failing on this PR vs. the 1.x-1.x branch.

https://github.com/backdrop-contrib/xmlsitemap/blob/1.x-1.x/xmlsitemap_node/tests/xmlsitemap_node.test#L41
That node is unpublished in the debug output I get so the fact the test fails is good, I think.

https://github.com/backdrop-contrib/xmlsitemap/blob/1.x-1.x/xmlsitemap_node/tests/xmlsitemap_node.test#L55
The node was now published but still failed.

And https://github.com/backdrop-contrib/xmlsitemap/blob/1.x-1.x/xmlsitemap_node/tests/xmlsitemap_node.test#L64 somehow has an illegal choice on the publishing options?

screen shot 2018-07-19 at 3 38 16 pm

Locally, I can't see any errors when I'm manually testing but my new testing site has like four links in it.

@alexfinnarn
Copy link
Contributor

nevermind, those fails make sense since the tests expect that the links are updated on node_update. So, the tests failing is actually a good thing.

I will add to the test-related issues to modify those to reflect not updating on node_update.

alexfinnarn pushed a commit that referenced this issue Jul 19, 2018
Issue #57: same fix as the Drupal version for sa-contrib-2018-053
@alexfinnarn
Copy link
Contributor

merged into 1.x branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants