New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled themes screenshots wrap funny #1047
Comments
Thanks @docwilmot! |
PR Ready for this one: backdrop/backdrop#991 |
Yikes, it's been a long time since this was filed. I found a few issues in the PR. @wesruv, do you think you could revisit this issue? |
Here's an updated PR that addresses @quicksketch's issues. I found that the 'fix' for |
@BWPanda care to refresh the PR sandbox? |
@klonos Done |
...wondering if it'd look better on narrow screens (when they are rendered in a single column) if the theme title/version, description, and "Enable" links we placed beside the theme thumbnails instead of bellow them: That way we'd put the white space to good use, and avoid too much scrolling when many themes are installed 😉 I've also left some feedback in the PR. |
I can no longer replicate this issue on the latest Backdrop 1.x... Can anyone else? If so, how? |
Based on the feedback from @klonos and @docwilmot, I made a new, simpler PR that I think fixes this, without a bunch of unnecessary, duplicated code: backdrop/backdrop#3239 |
Tested locally, works well. RTBC for me, although I am not great at CSS. |
Will wait for another review then before I commit this. |
Well, I also tested this locally and it worked for me. I reviewed the code and don't see any problems. But, I'm also not very familiar with css practices/standards in Backdrop CMS core. |
Thanks for filing this @docwilmot (and sorry for the delay)! Thank you @wesruv for the original PR on which the fix was based, and to @quicksketch, @klonos & @stpaultim for testing and feedback. I've merged backdrop/backdrop#3239 into 1.x and 1.16.x. |
@wesruv
Same as #988
PR: backdrop/backdrop#2853
The text was updated successfully, but these errors were encountered: