Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Update the Install X links to Install new Xs #1757

Closed
jenlampton opened this issue Mar 27, 2016 · 23 comments
Closed

[UX] Update the Install X links to Install new Xs #1757

jenlampton opened this issue Mar 27, 2016 · 23 comments

Comments

@jenlampton
Copy link
Member

jenlampton commented Mar 27, 2016

This was discussed in #998 and will be consistent with #1399.

What do we think?

  • Install new modules / Install new themes / Install new layouts
  • Install more modules / Install more themes / Install more layouts
  • Install other modules / Install other themes / Install other layouts
  • Install module package / Install theme package / Install layout package
  • Install module project / Install theme project / Install layout project
  • Add new module package / Add new theme package / Add new layout package
  • Add new module project / Add new theme project / Add new layout project
  • Find new module packages / Find new theme packages / Find new layout packages
  • Find new module projects / Find new theme projects / Find new layout projects
  • Find new modules / Find new themes / Find new layouts

PR from @jenlampton: backdrop/backdrop#1547

@jenlampton jenlampton changed the title [UX] Update the Install X links to Insall X project [UX] Update the Install X links to Insall X package Mar 27, 2016
@docwilmot docwilmot changed the title [UX] Update the Install X links to Insall X package [UX] Update the Install X links to Install X package Mar 28, 2016
@docwilmot
Copy link
Contributor

Perhaps the merging of Project Browser could help here, as in @quicksketch's suggestion at #998 (comment) we could change all these links to "Find new themes" or "Search for layouts" since we're rerouting these links to PB, so the "install" part would no longer be accurate anyway.

@jenlampton
Copy link
Member Author

That's a good point @docwilmot, I hadn't thought of that. I would like the language to indicate to users that the things they are "finding" are not already part of their site. Not sure how to do that without using "Install"... but open to suggestions!

I wonder what word WP uses on their plugins page?

@klonos
Copy link
Member

klonos commented Mar 29, 2016

I wonder what word WP uses on their plugins page?

Here you go 😉 :

wp-plugins_page

@jenlampton
Copy link
Member Author

Interesting, WP just says Add new with no noun. Also there is no indication that they can "search" or "find" from that page... it's just assumed.

I think we need the noun in Backdrop, but I'm fine with using "new" instead of "install". I could go either way with search/find.

@jenlampton jenlampton changed the title [UX] Update the Install X links to Install X package [UX] Update the Install X links to Find new X Mar 29, 2016
@jenlampton jenlampton added this to the 1.4.0 milestone Mar 29, 2016
@klonos
Copy link
Member

klonos commented Mar 29, 2016

...there is no indication that they can "search" or "find" from that page

My bad, not a full-width screenshot. Here's a better one:

wp-plugins-installed-search

...and there's also a search box in their "add plugins" page (their version of Project Browser):

wp-plugins-add_new-search

Anyways, I think that there is a distinct difference between "new"/"add"/"create" vs "install" and that using one in the place of the other can be misleading. "Add" is for example to be used for new content types or new content where the users create something new from scratch themselves. They add something that they can then edit (or update or delete). "Install" on the other hand is something ready-made that you just use as is. Once something is installed, you cannot edit it - you configure it (or enable or disable or uninstall*). Does that make sense?

@jenlampton
Copy link
Member Author

Yes, after reading your comment I agree with you again and want to use the word "Install". My favorite is now Install module project / Install theme project / Install layout project. back to being consistent with project browser. :)

What do others think?

@jenlampton jenlampton changed the title [UX] Update the Install X links to Find new X [UX] Update the Install X links to Install X project Mar 29, 2016
@klonos
Copy link
Member

klonos commented Mar 29, 2016

...perhaps they use "add" because they allow editing plugins through their UI:

wp-plugin_editor

@klonos
Copy link
Member

klonos commented Mar 29, 2016

...it would have already been in the list of the issues for the feature parity with WP if it wasn't for the security implications that come with it.

Although, I have to admit that it would be so much easier to simply copy the contents of a raw file from GitHub (from a PR) and paste it directly in the file instead of uploading patches and going through the command line.

@serundeputy
Copy link
Member

#gross;

@Bojhan
Copy link

Bojhan commented May 9, 2016

Installed makes sense, we also had this discussion for D8. In general using "add" when it refers to new entities of any type (content, comment, etc.) and "install" when refers to things which are downloaded and system level.

@serundeputy
Copy link
Member

Is this in relation to the Project Browser tabs on /admin/appearance/install and admin/modules or is this about something else?

I'm moving to 1.5, but feel free to put back if someone feels like the can want to tackle it by 15 May 2016.

thanks!

@serundeputy serundeputy modified the milestones: 1.5.0, 1.4.0 May 13, 2016
@docwilmot
Copy link
Contributor

I think this is sufficiently resolved by the new labels in Project Installer. If someone somehow still has an issue with this, reopen.

@klonos
Copy link
Member

klonos commented May 14, 2016

...well, we went form this very confusing thing (both "Add layout" and "Install layout" as + links):

layout

...to this ("Add layout" as a + link and "Install layouts" as a tab that opens the layout part of the Project Browser):

backdrop-layouts-add_link_vs_install_tab

Also, in #998 (still open) we were initially contemplating about what we should call the various things and I believe that there is currently a general consensus that both layout .tpl.php files and their respective UI representations (screenshot tile thingies) will be called "layout templates". So we are perfectly clear on that.

In the current situation though (and let me clarify here that I personally fully understand what each thing does - I am just trying to put myself in the shoes of newcomers), the UI might be confusing. So, I still thing that changing the tab from "Install layouts" to "Install layout packages" or "Install layout projects" would help clarify things.

Finally, in the spirit of being consistent throughout the UI, I think that there was also consensus on that if we changed this for the layouts, we'd also change the "Install themes" and "Install modules" text to include either the word "package" or "project". That is what this issue here is about.

My 2c

@docwilmot docwilmot reopened this May 14, 2016
@jenlampton jenlampton changed the title [UX] Update the Install X links to Install X project [UX] Update the Install X links to Install new Xs Sep 8, 2016
@quicksketch
Copy link
Member

Is there actually a PR for this change? I'm not seeing one in this thread.

@jenlampton
Copy link
Member Author

jenlampton commented Sep 13, 2016

branch was 1757-install-new. whoops. never made a PR. sorry! backdrop/backdrop#1547

@jenlampton
Copy link
Member Author

jenlampton commented Sep 15, 2016

I'm not sure I like any of these suggestions better than what we have now. We should discuss before we make this decision, and we don't have time to do that before tomorrow.

Here's the a screenshot of the latest:
screen shot 2016-12-15 at 3 20 43 pm

@jenlampton
Copy link
Member Author

I think this would be a minor UX win for 1.6, but we need some more feedback.

@klonos
Copy link
Member

klonos commented Dec 17, 2016

This is a very small (both UI- as well as code-wise) but nevertheless important change that improves UX. We should get it in. What sort of other feedback are you after @jenlampton??

PS: would be great if you closed/reopened the PR to get a fresh sandbox 😉

@jenlampton
Copy link
Member Author

jenlampton commented Dec 17, 2016

What sort of other feedback are you after @jenlampton??

We need consensus for the text on the tab, is "Install new modules" good to go, or do we want to bikeshed that some more? :)

PS: would be great if you closed/reopened the PR to get a fresh sandbox 😉

done!

@klonos
Copy link
Member

klonos commented Dec 17, 2016

PS: would be great if you closed/reopened the PR to get a fresh sandbox 😉

done!

You need to wait a couple of minutes before reopening after you have closed a PR, otherwise the sandbox fails to be properly destroyed and then rebuild. Can you please give it another go when you get a chance? Thanx.

@jenlampton
Copy link
Member Author

Well I'm glad somebody knows how things work around here :) trying again...

@klonos
Copy link
Member

klonos commented Dec 18, 2016

Just passing on the knowledge of how the cogs turn. It's basically advice previously passed on to me by @Gormartsen which is the person that actually has put the cogs together for us 😄

PR sandbox looks great and PR changes are trivial. RTBC from me 👍

@serundeputy
Copy link
Member

Thanks everyone! Looks good!

Merged into 1.x will ship with 1.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants