New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] FIX RTL Formatting options theme basis #3435

Closed
shabibalm opened this Issue Dec 18, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@shabibalm
Copy link

shabibalm commented Dec 18, 2018

problem Formatting options form comment
fix-rtl-formatting-options-theme-basis

edit core/themes/basis/css/component/fieldset.css
add

.js[dir="rtl"] fieldset.collapsible .fieldset-title {
  padding: 0.3em 1.8em 0.3em 0.3em;
}

and add

.js[dir="rtl"] fieldset.collapsed .fieldset-legend a:before {
  -webkit-transform:
    translate(0, 0.125em)
    rotate(90deg);
  transform:
    translate(0, 0.125em)
    rotate(90deg);
}

and add

.js[dir="rtl"] fieldset.collapsible .fieldset-legend a:before {
	right: 0.6em;
}

PR: backdrop/backdrop#2472

@jenlampton

This comment has been minimized.

Copy link
Member

jenlampton commented Jan 13, 2019

I've created a PR for testing this solution, if someone else could give it a try?
backdrop/backdrop#2472

@findlabnet

This comment has been minimized.

Copy link

findlabnet commented Jan 13, 2019

Bug fixed in PR.

@quicksketch

This comment has been minimized.

Copy link
Member

quicksketch commented Jan 14, 2019

Thanks @shabibalm, @jenlampton, and @findlabnet! Merged backdrop/backdrop#2472 into 1.x and 1.11.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment