New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Updates failing due to missing module 'type' in *.tests.info file #3447

Closed
stpaultim opened this Issue Dec 29, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@stpaultim
Copy link
Member

stpaultim commented Dec 29, 2018

Describe the bug
In issue - #3433, I have been trying to get Core Updates working locally using a fresh Lando installation without success.

It turns out that I'm getting an error even when enabling core updates manually and before applying the patch in issue - #3271

I'm opening this new issue, because this seems to be a bug in the original PR added to v 1.11.0 - #3105

I'm not sure what the bug was, but I reported it and @serundeputy was able to reproduce it and wrote a PR for it: backdrop/backdrop#2431 (but, I don't think there is any other issue for this PR yet).

I've tested this PR and I am still unable to get updates working.

Steps To Reproduce

  1. Setup environment with Lando
  • git clone git@github.com:backdrop/backdrop.git bd-updates
  • cd bd-updates
  • git checkout 1.11.0
  • wget https://github.com/backdrop/backdrop/pull/2431.patch
  • git apply 2431.patch
  • lando init
  • lando start
  • lando drush si --db-url=mysql://backdrop:backdrop@database/backdrop
  • In active/installer.settings.json change "core_update": false to "core_update": 1

Probably not necessary, but trying to be thorough (Adjust permissions and ownership as per - https://backdropcms.org/file-permissions-and-ownership)

In Backdrop root.

  • chown -R timothyerickson:staff .
  • find . -type f -exec chmod 664 '{}' \;
  • find . -type d -exec chmod 755 '{}' \;
  • chmod 774 index.php
  • chmod 774 core/install.php
  • chmod 774 core/update.php
  • chmod 774 core/cron.php

Login to site:

  • Go to: http://localhost:32773/admin/modules/update
  • Select Backdrop and "Download these updates"
  • See: Perform updates with site in maintenance mode (strongly recommended)
  • Select "Continue"
  • See error page with "The website encountered an unexpected error. Please try again later."
  • Check recent log messages and find: "UpdaterException: The info file (temporary://update-extraction-a2f14549/backdrop/core/modules/email/tests/email.tests.info) does not define a 'type' attribute. in Updater::getProjectType() (line 194 of /app/core/includes/updater.inc)."

Test module update

  • Install (manually copy it into the modules folder) Devel 1.x-1.6.0 (old version)
  • Enable Devel module
  • Go to: http://localhost:32773/admin/modules/update
  • Select Devel and "Download these updates"
  • Finish update
  • Module is updated successfully

Actual behavior

See error message above.

Expected behavior

Successful update.

Additional information

@stpaultim

This comment has been minimized.

Copy link
Member

stpaultim commented Dec 29, 2018

@serundeputy - FYI - I did try with the shorter script that you provided as well. Getting the same error both ways. #3433 (comment)

@serundeputy

This comment has been minimized.

Copy link
Member

serundeputy commented Dec 30, 2018

@stpaultim what php version are you running?

@stpaultim

This comment has been minimized.

Copy link
Member

stpaultim commented Dec 30, 2018

According to the Backdrop CMS status page, I'm running PHP v 7.0.33
I dropped a phpinfo.php in Backdrop root and that is telling me the same thing (as I would expect).

I may have other versions of php installed on my laptop, but doesn't Lando and/or the Backdrop recipe determine which version of php is being used?

FYI: This is what my .lando.yml file looks like:

name: 'test'
recipe: backdrop
config:
webroot: .

@serundeputy

This comment has been minimized.

Copy link
Member

serundeputy commented Dec 31, 2018

yes; lando determines the php version (for backdrops that are running via lando)

@jenlampton jenlampton added this to the 1.11.4 milestone Jan 2, 2019

@jenlampton jenlampton changed the title Core Updates failing - before turning on the UI Core Updates failing due to missing module 'type' Jan 2, 2019

@jenlampton jenlampton changed the title Core Updates failing due to missing module 'type' Core Updates failing due to missing module 'type' in *.tests.info file Jan 2, 2019

@klonos

This comment has been minimized.

Copy link
Member

klonos commented Jan 4, 2019

Is this a duplicate of #1294 ?

@jenlampton

This comment has been minimized.

Copy link
Member

jenlampton commented Jan 15, 2019

Is this a duplicate of #1294?

yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment