Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] CKEditor configuration: Add a label to the "button separator" button #3666

Open
klonos opened this issue Apr 13, 2019 · 2 comments
Open

Comments

@klonos
Copy link
Member

klonos commented Apr 13, 2019

Backdrop:

Screen Shot 2019-04-14 at 5 37 36 am

D8:

Seven - CKEditor settings toolbar

Tooltips do not work on devices with touch screens, so we should add a label to this button.

@klonos
Copy link
Member Author

klonos commented Apr 13, 2019

I have tried to take a stab at this, but the "Button separator" button seems to be rendered as part of a "multiple buttons" group (which are buttons that can be placed multiple times in the CKEditor toolbar). Right now, this button is the only button in that group, so adding a "Button separator" label as a span to the entire group does work visually, but it is not future-proof. In other words, when/if more such "multiple buttons" are added in the future, the label needs to apply to all of them; not just the separator.

So, if we add the label to the button, it will look like so:

Screen Shot 2019-04-14 at 7 13 44 am

...and if we add it to the group, it'll look like so:

Screen Shot 2019-04-14 at 7 16 45 am

So, do we special-case the separator button and move it out of the "multiple buttons" group, into its own group? Do we add multiple "multiple buttons" groups and keep one only for the separator button? ...or do we add the label to the button (which IMO does not look good visually)?

Thoughts?

@klonos
Copy link
Member Author

klonos commented Apr 13, 2019

...the solution to this problem would be very simple, if the answer to the following question is yes:

Is it safe to assume that the button separator is the only button that will ever be a "multiple button"?

@jenlampton jenlampton added this to Ideas in Rich-Text Editor Apr 27, 2019
@jenlampton jenlampton moved this from To do to Done in Parity w Modern Drupal Apr 28, 2019
@jenlampton jenlampton removed this from Done in Parity w Modern Drupal Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant