New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling JavaScript with Views doesn't work properly #4283
Comments
Confirmed, views still uses js/ajax for some buttons, even if this setting is active. But... Should we remove it in Backdrop, too? |
My opinion is that if it's not possible to fix it, then removing is better than leaving at the current state, which looks like broken. |
I'm all for removing that setting. FTR: this is the related Drupal issue. So here's a PR. I need some guidance regarding function views_update_2000() - is that done the right way? Is the numbering correct? |
@indigoxela You'd use |
Yeah, that's why I ask here. The comment text somewhat confuses me:
|
So that comment matches this initial comment: https://github.com/backdrop/backdrop/blob/9ed127933df9994ec3e96f9110520359451a183d/core/modules/views/views.install#L29 Basically everything between them is the updates for people upgrading from Drupal 7 or Backdrop 1. Hence everything after that final comment is for Backdrop 2. Your |
@BWPanda many thanks for your explanation. This "addtogroup updates-7.x-to-1.x" really confused me. PR has been updated. |
Looks good |
Thanks @indigoxela for the PR! I've merged backdrop/backdrop#3050 into 1.x and 1.16.x. Thanks @alanmels for reporting this issue. And @BWPanda and @herbdool for reviewing the PR and providing input. 😄 |
Thanks for working on this guys! |
This might be related to #3734, but since I was not sure I decided to file a separate bug report.
Description of the bug
Disabling JavaScript on Views' Advanced settings page (http://view.docksal/admin/structure/views/settings/advanced) does not have full effect: it does open the option links on a regular window (instead of a pop-up modal one), but it does not close the option page to return to the initial page.
Steps To Reproduce
To reproduce the behavior:
/admin/structure/views/settings/advanced
, select theDisable JavaScript with Views
option and press on theSave Settings
button.Administer content (Content)
atadmin/structure/views/view/node_admin_content
)./admin/structure/views/nojs/display/node_admin_content/page/path
.Expected behavior
Expected behavior was returning to previous screen as on Drupal 7:
The text was updated successfully, but these errors were encountered: