Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 Invalid characters in Color module base conversion functions #4474

Closed
alanmels opened this issue Jul 8, 2020 · 2 comments · Fixed by backdrop/backdrop#3186
Closed

Comments

@alanmels
Copy link

alanmels commented Jul 8, 2020

Description of the bug

When changing the color set for Basis theme on a system with PHP 7.4 it gives the error:

Deprecated function: Invalid characters passed for attempted conversion, these have been ignored in _color_unpack() (line 875 of /home/in/public_html/core/modules/color/color.module).

Additional information

This has been fixed for Drupal 7 four month ago: https://www.drupal.org/project/drupal/issues/3084955
Also read https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.invalid-base-characters

@klonos
Copy link
Member

klonos commented Jul 8, 2020

Thanks @alanmels 👍 ...I've tested on my local with php 7.4.7, first on a vanilla Backdrop installation, and I was able to reproduce the problem. I then pulled your PR on my local, re-built the site and tested again to verify that there are no errors.

I've also reviewed the PR, and it matches the one for D7, so RTBC 👍

@quicksketch
Copy link
Member

Thanks @alanmels! I've merged backdrop/backdrop#3186 into 1.x and 1.16.x.

@quicksketch quicksketch added this to the 1.16.3 milestone Jul 9, 2020
@quicksketch quicksketch changed the title Invalid characters in base conversion functions PHP 7.4 Invalid characters in Color module base conversion functions Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants