New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Make autocomplete suggestions easier to read #4481
Comments
I've filed a PR: backdrop/backdrop#3189 ...I went with grayed-out descriptions ( |
How widespread is this change? Are there other core autocomplete menus that would be effected by this? On the surface, this is visually a nice improvement and I support it. I'm just trying to think of unintended sites effects or whether or not we have any conflicting styles choices elsewhere in Backdrop CMS. |
I like the grey and the smaller text, and that it matches machine name styling 👍 |
Thanks for the feedback all 🙏 ...this is ready for another round of review/testing. I've made the classes more specific, as per @quicksketch's suggestion during the dev meeting ( Also made sure that the suggestion descriptions are properly positioned in RTL. Before: |
@klonos I reviewed the code and made some cleanup suggestions. |
Thanks @BWPanda 👍 ...nice catch with the Views matches description; I was doing some weird variable usage in that As for the space string concatenations, I've fixed them too, but we do not mention anything about that in https://api.backdropcms.org/php-standards#string-concatenation (nor does the respective documentation in d.org: https://www.drupal.org/docs/develop/standards/coding-standards#concat). We should either allow that, or add something about it in the coding standards documentation 😉 |
I'd have thought because it was common sense not to concatenate strings together without some sort of variable in between. Like, we wouldn't do: Sorry, not having a go at you. I realise it was probably left-over from something being removed at some point. If you think it's worth adding to the standards documentation, we can do that. I just figure it's a fairly basic thing that doesn't need to be specified as such... THanks for the changes, looks good to me. Just some test failures that I can't see details of because CI's playing up again... |
No worries @BWPanda 😄 ...I'm not too fussed about it either. This was actually a left-over form when I had the code like this: $match_description = '<span class="autocomplete-description">(' . t('User account') . ')</span>';
$matches[$path] = $match . ' ' . $match_description; ...I then moved the $match_description = t('User account');
$matches[$path] = $match . ' ' . '<span class="autocomplete-description">(' . $match_description . ')</span>'; All good 👍 Re test failures, I know 😓 ...ZenCI has been giving me a hard time for some time now. I've restarted them 🤞 |
All tests are finally green 👍 |
Nice! RTBC from me. |
…dropdown. By @klonos and @BWPanda.
…dropdown. By @klonos and @BWPanda.
Thanks @klonos and @BWPanda for your work on this! I merged backdrop/backdrop#3189 into 1.x and 1.16.x. |
Makes it hard to distinguish the actual options with all the additional info:
The text was updated successfully, but these errors were encountered: