From 1773a5182b2a0d6703933a2b633aeb70813d4380 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Wed, 30 Dec 2020 17:01:35 +0100
Subject: [PATCH] create-app: removed lighthouse plugin from default template

---
 .changeset/twenty-llamas-sin.md                      | 12 ++++++++++++
 .../templates/default-app/app-config.yaml.hbs        |  3 ---
 .../default-app/packages/app/package.json.hbs        |  1 -
 .../default-app/packages/app/src/plugins.ts          |  1 -
 .../default-app/packages/app/src/sidebar.tsx         |  2 --
 5 files changed, 12 insertions(+), 7 deletions(-)
 create mode 100644 .changeset/twenty-llamas-sin.md

diff --git a/.changeset/twenty-llamas-sin.md b/.changeset/twenty-llamas-sin.md
new file mode 100644
index 0000000000000..30690cfdc06b5
--- /dev/null
+++ b/.changeset/twenty-llamas-sin.md
@@ -0,0 +1,12 @@
+---
+'@backstage/create-app': patch
+---
+
+Removed lighthouse plugin from the default set up plugins, as it requires a separate Backend to function.
+
+To apply this change to an existing app, remove the following:
+
+1. The `lighthouse` block from `app-config.yaml`.
+2. The `@backstage/plugin-lighthouse` dependency from `packages/app/package.json`.
+3. The `@backstage/plugin-lighthouse` re-export from `packages/app/src/plugins.ts`.
+4. The Lighthouse sidebar item from `packages/app/src/sidebar.tsx`, and the `RuleIcon` import if it is unused.
diff --git a/packages/create-app/templates/default-app/app-config.yaml.hbs b/packages/create-app/templates/default-app/app-config.yaml.hbs
index 7b70a2192c495..90f272270a018 100644
--- a/packages/create-app/templates/default-app/app-config.yaml.hbs
+++ b/packages/create-app/templates/default-app/app-config.yaml.hbs
@@ -65,9 +65,6 @@ techdocs:
   publisher:
     type: 'local'
 
-lighthouse:
-  baseUrl: http://localhost:3003
-
 auth:
   # see https://backstage.io/docs/tutorials/quickstart-app-auth to know more about enabling auth providers
   providers: {}
diff --git a/packages/create-app/templates/default-app/packages/app/package.json.hbs b/packages/create-app/templates/default-app/packages/app/package.json.hbs
index 48ab600c973ec..e40ed6f03d45a 100644
--- a/packages/create-app/templates/default-app/packages/app/package.json.hbs
+++ b/packages/create-app/templates/default-app/packages/app/package.json.hbs
@@ -15,7 +15,6 @@
     "@backstage/plugin-techdocs": "^{{version '@backstage/plugin-techdocs'}}",
     "@backstage/catalog-model": "^{{version '@backstage/catalog-model'}}",
     "@backstage/plugin-circleci": "^{{version '@backstage/plugin-circleci'}}",
-    "@backstage/plugin-lighthouse": "^{{version '@backstage/plugin-lighthouse'}}",
     "@backstage/plugin-tech-radar": "^{{version '@backstage/plugin-tech-radar'}}",
     "@backstage/plugin-github-actions": "^{{version '@backstage/plugin-github-actions'}}",
     "@backstage/plugin-user-settings": "^{{version '@backstage/plugin-user-settings'}}",
diff --git a/packages/create-app/templates/default-app/packages/app/src/plugins.ts b/packages/create-app/templates/default-app/packages/app/src/plugins.ts
index 182ec3c51cf6d..d3c9d6e2f3315 100644
--- a/packages/create-app/templates/default-app/packages/app/src/plugins.ts
+++ b/packages/create-app/templates/default-app/packages/app/src/plugins.ts
@@ -3,7 +3,6 @@ export { plugin as CatalogPlugin } from '@backstage/plugin-catalog';
 export { plugin as CatalogImport } from '@backstage/plugin-catalog-import';
 export { plugin as Circleci } from '@backstage/plugin-circleci';
 export { plugin as GithubActions } from '@backstage/plugin-github-actions';
-export { plugin as LighthousePlugin } from '@backstage/plugin-lighthouse';
 export { plugin as ScaffolderPlugin } from '@backstage/plugin-scaffolder';
 export { plugin as TechDocsPlugin } from '@backstage/plugin-techdocs';
 export { plugin as TechRadar } from '@backstage/plugin-tech-radar';
diff --git a/packages/create-app/templates/default-app/packages/app/src/sidebar.tsx b/packages/create-app/templates/default-app/packages/app/src/sidebar.tsx
index a5595e2c091cf..d1f07bd132f70 100644
--- a/packages/create-app/templates/default-app/packages/app/src/sidebar.tsx
+++ b/packages/create-app/templates/default-app/packages/app/src/sidebar.tsx
@@ -4,7 +4,6 @@ import LibraryBooks from '@material-ui/icons/LibraryBooks';
 import ExtensionIcon from '@material-ui/icons/Extension';
 import CreateComponentIcon from '@material-ui/icons/AddCircleOutline';
 import BuildIcon from '@material-ui/icons/BuildRounded';
-import RuleIcon from '@material-ui/icons/AssignmentTurnedIn';
 import MapIcon from '@material-ui/icons/MyLocation';
 import { Link, makeStyles } from '@material-ui/core';
 import { NavLink } from 'react-router-dom';
@@ -34,7 +33,6 @@ export const AppSidebar = () => (
     <SidebarItem icon={CreateComponentIcon} to="create" text="Create..." />
     <SidebarDivider />
     <SidebarItem icon={MapIcon} to="tech-radar" text="Tech Radar" />
-    <SidebarItem icon={RuleIcon} to="lighthouse" text="Lighthouse" />
     <SidebarItem icon={BuildIcon} to="circleci" text="CircleCI" />
     {/* End global nav */}
     <SidebarDivider />