From fae2aee8785686f0d96bb486d2ea35190b1ba35d Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Mon, 7 Feb 2022 12:23:44 +0100 Subject: [PATCH] cli: remove no-duplicates lint rule Signed-off-by: Patrik Oldsberg --- .changeset/pretty-glasses-admire.md | 9 +++++++++ packages/cli/config/eslint.backend.js | 1 - packages/cli/config/eslint.js | 1 - 3 files changed, 9 insertions(+), 2 deletions(-) create mode 100644 .changeset/pretty-glasses-admire.md diff --git a/.changeset/pretty-glasses-admire.md b/.changeset/pretty-glasses-admire.md new file mode 100644 index 0000000000000..318271ddc9559 --- /dev/null +++ b/.changeset/pretty-glasses-admire.md @@ -0,0 +1,9 @@ +--- +'@backstage/cli': patch +--- + +Removed the `import/no-duplicates` lint rule from the frontend and backend ESLint configurations. This rule is quite expensive to execute and only provides a purely cosmetic benefit, so we opted to remove it from the set of default rules. If you would like to keep this rule you can add it back in your local ESLint configuration: + +```js + 'import/no-duplicates': 'warn' +``` diff --git a/packages/cli/config/eslint.backend.js b/packages/cli/config/eslint.backend.js index 0aec1c247f3df..519b388b96a85 100644 --- a/packages/cli/config/eslint.backend.js +++ b/packages/cli/config/eslint.backend.js @@ -54,7 +54,6 @@ module.exports = { 'no-console': 0, // Permitted in console programs 'new-cap': ['error', { capIsNew: false }], // Because Express constructs things e.g. like 'const r = express.Router()' 'import/newline-after-import': 'error', - 'import/no-duplicates': 'warn', 'import/no-extraneous-dependencies': [ 'error', { diff --git a/packages/cli/config/eslint.js b/packages/cli/config/eslint.js index e81e309f72934..06f22933e8cbc 100644 --- a/packages/cli/config/eslint.js +++ b/packages/cli/config/eslint.js @@ -49,7 +49,6 @@ module.exports = { '@typescript-eslint/no-redeclare': 'error', 'no-undef': 'off', 'import/newline-after-import': 'error', - 'import/no-duplicates': 'warn', 'import/no-extraneous-dependencies': [ 'error', {