Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend-common: validate zip archive paths when unpacking into a dir #13054

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

Rugvip
Copy link
Member

@Rugvip Rugvip commented Aug 9, 2022

Hey, I just made a Pull Request!

Low priority fix as zip archives can currently only be read from trusted sources and the library we currently use also validates the same thing. Best have this check here either way.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Rugvip added 2 commits August 9, 2022 18:28
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
@Rugvip Rugvip requested review from a team as code owners August 9, 2022 16:29
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/backend-common packages/backend-common patch v0.15.0-next.1

@Rugvip Rugvip merged commit f4bc14e into master Aug 9, 2022
@Rugvip Rugvip deleted the rugvip/safechild branch August 9, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants