New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins: add GitHub Release Manager #5299
plugins: add GitHub Release Manager #5299
Conversation
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plugin looks great; pretty neat idea!
Note, the name is roughly similar to the one here #3729, though the feedback I and others had had in there was that the other plugin likely shouldn't be a generic release manager but a specific mobile release manager, so I don't think this one needs to change.
A query on the positioning/intent of the plugin. Throughout the doco and code you refer to GHE. This infers two things for me: 1) this plugin only supports GitHub Enterprise, and will not work with GitHub.com, and 2) this plugin only supports GitHub and so it's not so much Release Manager as a Service but more specifically a "GitHub Release Manager".
Can you elaborate on your positioning any further? I think if the scope is kept small it may be best to ensure it's clearly product specific, in which case folks who use GitLab, BitBucket, or other SCM providers would immediately know the "GitHub Release Manager" plugin isn't something they'd be interested in.
Alternatively, if it's a starting point for further development, then any place we refer to GitHub might need to be more generic such that we could plugin other providers - potentially capitalizing on Backstage's existing integration configuration - to support different providers. (with this early release only supporting GitHub, but other contributors could add GitLab or Bitbucket and so on)
So all in all really nice direction, love the server part, and hope you don't mind the questions. Great contrib!! 👏
plugins/release-manager-as-a-service/src/ReleaseManagerAsAService.tsx
Outdated
Show resolved
Hide resolved
plugins/release-manager-as-a-service/src/ReleaseManagerAsAService.tsx
Outdated
Show resolved
Hide resolved
plugins/release-manager-as-a-service/src/cards/createRc/CreateRc.tsx
Outdated
Show resolved
Hide resolved
plugins/release-manager-as-a-service/src/cards/createRc/getRcGheInfo.test.ts
Outdated
Show resolved
Hide resolved
plugins/release-manager-as-a-service/src/cards/createRc/sideEffects/createGheRc.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
2722883
to
33aa168
Compare
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
…ugin-release-manager-as-a-service
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Great input 👍 The plugin was initially created in a GHE environment, hence the sprinkled
For now I'm happy with rebranding
Cheers 🙌 |
Is this applicable for completely new plugins as well? |
plugins/github-release-manager/src/cards/createRc/sideEffects/createRc.ts
Outdated
Show resolved
Hide resolved
plugins/github-release-manager/src/components/ResponseStepList/ResponseStepList.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
e6721cb
to
6691570
Compare
@adamdmharvey thanks for the approval! I got some internal feedback on the PR yesterday (see Todo in PR description), so it turns out there's a bit of work yet 🙂 |
…Stratefy match at an earlier stage Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
…ugin-release-manager-as-a-service
…ugin-release-manager-as-a-service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phew! Finally done :) Obviously very lovingly crafted - well made!
plugins/git-release-manager/src/features/Stats/Row/RowCollapsed/RowCollapsed.tsx
Show resolved
Hide resolved
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
…ugin-release-manager-as-a-service
…git.createTag Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
…ugin-release-manager-as-a-service
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
…ugin-release-manager-as-a-service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job, let's ship and iterate!
@adamdmharvey I'm happy now! You good too? |
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
GitHub Release Manager (GRM)
Context
taken from the readme
GRM
enables developers to manage their releases without having to juggle git commands.Does it build and ship your code? No.
What
GRM
does is manage your releases on GitHub, building and shipping is entirely up to you as a developer to handle in your CI.GRM
is built with industry standards in mind and the flow is as follows:Plugin screenshots
This is what the plugin looks like in action
✔️ Checklist
Signed-off-by
line in the message. (more info)