Skip to content

node: fix invalid error handler in fileChunkSink #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024
Merged

node: fix invalid error handler in fileChunkSink #322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/node/src/streams/fileChunkSink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ interface FileChunkSinkOptions {
/**
* File system implementation to use.
*/
readonly fs?: NodeFileSystem;
readonly fs: NodeFileSystem;
}

/**
Expand Down Expand Up @@ -70,7 +70,7 @@ export class FileChunkSink extends EventEmitter {
private emitDeleteOrDelete(file: fs.WriteStream) {
// If 'delete' event is not handled, delete the file
if (!this.emit('delete', file)) {
(this._options.fs ?? fs).unlink(file.path.toString('utf-8'), () => {
this._options.fs.unlink(file.path.toString('utf-8')).catch(() => {
// Do nothing on error
});
}
Expand Down
Loading