xbox native client: fixes output directory for minidumps #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the updated API of backtrace_native_xbox.dll, previously backtrace_native_xbox_mt.dll, to specify a path for writing dump files. Prior to this commit, it was unpredictable as to whether a minidump could be written or not as the current directory of the process was (unintentionally) being used. With this change, minidumps are written to the value specified by the configuration's database path is passed which, by default, is `Application.persistentDataPath`. Removed unused exports, BacktraceCrash, used only for debugging, and BacktraceSetUrl, which was folded into BacktraceNativeXboxInit. The change will require updating to the latest backtrace_native_xbox.dll. [Internal Ref BT-509]
konraddysput
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the updated API of backtrace_native_xbox.dll, previously backtrace_native_xbox_mt.dll, to specify a path for writing dump files. Prior to this commit, it was unpredictable as to whether a minidump could be written or not as the current directory of the process was (unintentionally) being used.
With this change, minidumps are written to the value specified by the configuration's database path is passed which, by default, is
Application.persistentDataPath.Removed unused exports, BacktraceCrash, used only for debugging, and BacktraceSetUrl, which was folded into BacktraceNativeXboxInit.
The change will require updating to the latest backtrace_native_xbox.dll.
[Internal Ref BT-509]