Skip to content

uname.sysname update #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

uname.sysname update #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Runtime/Common/SystemHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ internal static bool IsLibraryAvailable(string[] libraries)
/// </summary>
/// <param name="architecture">System architecture</param>
/// <returns>System name</returns>
internal static string Name(string architecture)
internal static string Name()
{
#pragma warning disable CS0618 // Type or member is obsolete
switch (Application.platform)
Expand All @@ -80,9 +80,9 @@ internal static string Name(string architecture)
case RuntimePlatform.OSXPlayer:
return "Mac OS";
case RuntimePlatform.PS3:
return "PS3";
return "ps3";
case RuntimePlatform.PS4:
return "PS4";
return "ps4";
case RuntimePlatform.TizenPlayer:
case RuntimePlatform.SamsungTVPlayer:
return "Samsung TV";
Expand All @@ -93,7 +93,7 @@ internal static string Name(string architecture)
case RuntimePlatform.WiiU:
return "WiiU";
case RuntimePlatform.Switch:
return "Switch";
return "switch";
case RuntimePlatform.WindowsEditor:
case RuntimePlatform.WindowsPlayer:
case RuntimePlatform.WSAPlayerARM:
Expand All @@ -104,7 +104,7 @@ internal static string Name(string architecture)
case RuntimePlatform.XboxOne:
return "Xbox";
default:
return "NaCl";
return Application.platform.ToString();
}
}

Expand Down
2 changes: 1 addition & 1 deletion Runtime/Model/JsonData/BacktraceAttributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ private void SetMachineAttributes(bool onlyBuiltInAttributes = false)
Attributes["uname.machine"] = cpuArchitecture;
}
//Operating system name = such as "windows"
Attributes["uname.sysname"] = SystemHelper.Name(cpuArchitecture);
Attributes["uname.sysname"] = SystemHelper.Name();

//The version of the operating system
Attributes["uname.version"] = Environment.OSVersion.Version.ToString();
Expand Down