do not embed version and timestamp information #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#54 introduced the timestamp
date
to honor the SOURCE_DATE_EPOCH. This is insufficient if the reproducibility goal is to reproduce under any LOCALE (since the output ofdate
depends on the locale set in your environment).From #54
Actually, I don't even remember why I chose to have the compilation date as part of the information contained in ocamlgraph. I could simply remove it.
, this is why I open this PR which removes the timestamp and version information from ocamlgraph.If you think there's value in version or date informaion, I'm fine adjusting this PR to remove less. I (non-exhaustively) searched for users of
Graph.Version.
and couldn't find any. I usually install ocamlgraph via opam, and in this case the version information is carried by other means (META) already.