New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "--quiet" or "-q" option to perform #102

Merged
merged 1 commit into from Apr 29, 2011

Conversation

Projects
None yet
3 participants
@rspeicher
Contributor

rspeicher commented Apr 12, 2011

Silences STDOUT output from Backup::Logger

It wasn't clear to me how you go about testing bin/backup, so I haven't done anything with that beyond making sure the option shows up in help output.

Written to fix #101

Add a "--quiet" or "-q" option to perform
Silences STDOUT output from Backup::Logger
@@ -77,6 +78,12 @@ class BackupCLI < Thor
end
##
# Silence Backup::Logger from printing to STDOUT, if --quiet was specified
if options[:quiet]
Backup::Logger.send(:const_set, :QUIET, options[:quiet])

This comment has been minimized.

@rspeicher

rspeicher Apr 12, 2011

Contributor

Slightly breaking from convention here, as all the constants seem to be defined on Backup itself, but as this option only applies to the Logger I felt it fit better there.

@rspeicher

rspeicher Apr 12, 2011

Contributor

Slightly breaking from convention here, as all the constants seem to be defined on Backup itself, but as this option only applies to the Logger I felt it fit better there.

@mrrooijen

This comment has been minimized.

Show comment
Hide comment
@mrrooijen

mrrooijen Apr 29, 2011

Member

Aight. I finally got around to work on Backup again, so I'm drilling through all the pull requests and feature requests now to see what can be done. I'm going to merge in your additions since it looks good.

Thanks! This'll be available in 3.0.15 which I'll be pushing out soon.

Member

mrrooijen commented Apr 29, 2011

Aight. I finally got around to work on Backup again, so I'm drilling through all the pull requests and feature requests now to see what can be done. I'm going to merge in your additions since it looks good.

Thanks! This'll be available in 3.0.15 which I'll be pushing out soon.

mrrooijen pushed a commit that referenced this pull request Apr 29, 2011

Michael van Rooijen
Merged pull request #102 from tsigo/develop.
Add a "--quiet" or "-q" option to perform

@mrrooijen mrrooijen merged commit dcdc3bf into backup:develop Apr 29, 2011

@sobrinho

This comment has been minimized.

Show comment
Hide comment
@sobrinho

sobrinho Apr 30, 2011

An accessor will be more cleaner :)

sobrinho commented on 6bc7b1c Apr 30, 2011

An accessor will be more cleaner :)

This comment has been minimized.

Show comment
Hide comment
@rspeicher

rspeicher Apr 30, 2011

Contributor

I agree, but I was matching the style that was already established.

Contributor

rspeicher replied Apr 30, 2011

I agree, but I was matching the style that was already established.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment