update for riak backup output file #360

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

jlambert121 commented Sep 14, 2012

riak-admin backup appends the node name on the end of the backup file specified. Compress subsequently fails because the filename provided to riak-admin isn't the actual filename created. This patch appends the node name to the input file for the compressor.

Contributor

jlambert121 commented Sep 14, 2012

Initial commit and pull request did not properly clean up the original dump file. This commit fixes this.

Contributor

tomash commented Sep 20, 2012

since this has no test coverage, we need some other riak users to confirm this indeed works as expected. any volunteers?

awaage commented Oct 12, 2012

Confirming this fix works for backing up Riak with compression.

Happened to run into the same issue. I would have committed the same patch, but glad to see it was fixed already. Thanks jlambert121!

Contributor

jlambert121 commented Nov 6, 2012

@tomash - anything else I can do to get this merged?

Contributor

tomash commented Nov 6, 2012

i'd like to ask @meskyanichi before merging stuff that's not covered with tests. michael, what do you think?

Contributor

jlambert121 commented Jan 4, 2013

any chance this can get merged into the next release?

Contributor

jlambert121 commented Jan 8, 2013

@meskyanichi any thoughts? I can build a riak machine for you to test on if needed.

@ghost

ghost commented Jan 10, 2013

I don't see any problem with this, since we have 2 users confirming this works.
Specs updated and changes pushed to 'develop'.

@ghost ghost closed this Jan 10, 2013

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment