Add support for notifying via Pushover #381

Merged
merged 1 commit into from Nov 17, 2012

Projects

None yet

3 participants

@SteveNewson

Pushover provides an API through which you can push notifications to registered applications. This change is to support notification via this API. It uses the Pushover Gem to do this.

@tomash
tomash commented Nov 11, 2012

the code looks strong. anyone here using pushover and willing to give it a test drive?

@SteveNewson SteveNewson commented on an outdated diff Nov 11, 2012
lib/backup/version.rb
@@ -13,7 +13,7 @@ class Version
# Defines the minor version
# PATCH:
# Defines the patch version
- MAJOR, MINOR, PATCH = 3, 0, 25
+ MAJOR, MINOR, PATCH = 3, 0, 26
@SteveNewson
SteveNewson Nov 11, 2012

Note I changed the version number - you may not want to pull this.

@tomash
tomash commented Nov 11, 2012

so, can you add a commit that reverts version to 3.0.25 and squash them all into one? also please rebase with current master, otherwise the latest mocha will show your build as broken.

@SteveNewson

Sure. Only after I did the change did I read that you wanted branches from the develop branch. D'oh!

@tomash
tomash commented Nov 11, 2012

ouch, didn't know about it -- my glacier work (#380) is also based off master

@SteveNewson

OK, so I've made the change and squashed the commits into one. I'm afraid I'm a little new to Git, so I'm not sure what you want me to do next (my profound apologies!). Should I create a new pull request? And, how do I rebase my branch with the current master? Sorry.

@tomash
tomash commented Nov 11, 2012

don't worry with rebasing yet (your work should merge cleanly). as for squashed commits, just do a push --force into the same branch that you made this pull request from.

@SteveNewson

OK. Done.

@tomash
tomash commented Nov 12, 2012

it fails the tests on ruby 1.8.7 because you're using the new 1.9-only hash syntax. we want this gem 1.8-compatible, so please fix it:
https://travis-ci.org/meskyanichi/backup/jobs/3152933

@SteveNewson

OK, after some reading of the Pro Git book and a couple of aborted attempts to get 1.8.7 to build on OSX (!), I've managed to get a squashed commit which builds. This required removing the dependency on the Pushover gem which doesn't support 1.8.7. However, we didn't need all the bells and whistles provided by the gem, it's just a post to a REST API with a JSON payload. This has gone green in CI: https://travis-ci.org/meskyanichi/backup/builds/3186845

@tomash
tomash commented Nov 13, 2012

awesome, you're the man!

so, any objections people, or can we merge this? :)

@mrrooijen
Member

Looks good. Ill merge it in. Thanks!

@mrrooijen
Member

@SteveNewson mind adding an entry with more information regarding PushOver to the Wiki? https://github.com/meskyanichi/backup/wiki/Notifiers

This would help people unfamiliar with this service/tool to get up and running easier.

@mrrooijen mrrooijen merged commit aac7898 into backup:master Nov 17, 2012
@SteveNewson

Sure. I'll update as soon as I'm back in front of a computer :). Should probably also update the readme

@mrrooijen
Member

Excellent. No rush, just whenever you have time. I'll update the README now, and release a new patch version of the gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment