Pushover provides an API through which you can push notifications to registered applications. This change is to support notification via this API. It uses the Pushover Gem to do this.
the code looks strong. anyone here using pushover and willing to give it a test drive?
Note I changed the version number - you may not want to pull this.
so, can you add a commit that reverts version to 3.0.25 and squash them all into one? also please rebase with current master, otherwise the latest mocha will show your build as broken.
Sure. Only after I did the change did I read that you wanted branches from the develop branch. D'oh!
ouch, didn't know about it -- my glacier work (#380) is also based off master
OK, so I've made the change and squashed the commits into one. I'm afraid I'm a little new to Git, so I'm not sure what you want me to do next (my profound apologies!). Should I create a new pull request? And, how do I rebase my branch with the current master? Sorry.
don't worry with rebasing yet (your work should merge cleanly). as for squashed commits, just do a push --force into the same branch that you made this pull request from.
it fails the tests on ruby 1.8.7 because you're using the new 1.9-only hash syntax. we want this gem 1.8-compatible, so please fix it:
Added support for Pushover
OK, after some reading of the Pro Git book and a couple of aborted attempts to get 1.8.7 to build on OSX (!), I've managed to get a squashed commit which builds. This required removing the dependency on the Pushover gem which doesn't support 1.8.7. However, we didn't need all the bells and whistles provided by the gem, it's just a post to a REST API with a JSON payload. This has gone green in CI: https://travis-ci.org/meskyanichi/backup/builds/3186845
awesome, you're the man!
so, any objections people, or can we merge this? :)
Looks good. Ill merge it in. Thanks!
@SteveNewson mind adding an entry with more information regarding PushOver to the Wiki? https://github.com/meskyanichi/backup/wiki/Notifiers
This would help people unfamiliar with this service/tool to get up and running easier.
Sure. I'll update as soon as I'm back in front of a computer :). Should probably also update the readme
Excellent. No rush, just whenever you have time. I'll update the README now, and release a new patch version of the gem.