Add support for backing up MongoDB database files directly #415

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@benmccann

This is a faster and more scalable solution for large datasets.

Add support for backing up MongoDB database files directly rather tha…
…n through mongodump. This is a faster and more scalable solution for large datasets.
db.only_collections.should == ['users', 'pirates']
- db.additional_options.should == ['--query', '--foo']
+ db.mongodump_options .should == ['--query', '--foo']

This comment has been minimized.

Show comment Hide comment
@guilhem

guilhem Apr 11, 2013

Contributor

Is space between "mongodump_options" and ".should" desired?

@guilhem

guilhem Apr 11, 2013

Contributor

Is space between "mongodump_options" and ".should" desired?

This comment has been minimized.

Show comment Hide comment
@tombruijn

tombruijn Sep 12, 2014

Owner

It is not

@tombruijn

tombruijn Sep 12, 2014

Owner

It is not

db.lock = false
# Optional: Use to set the location of these utilities
# if they cannot be found by their name in your $PATH
# db.mongodump_utility = "/opt/local/bin/mongodump"
# db.mongo_utility = "/opt/local/bin/mongo"
- end
+ end

This comment has been minimized.

Show comment Hide comment
@tombruijn

tombruijn Sep 12, 2014

Owner

No newline at end of file

@tombruijn

tombruijn Sep 12, 2014

Owner

No newline at end of file

@@ -131,7 +139,7 @@
db.ipv6.should == 'default_ipv6'
db.only_collections.should == ['collection']
- db.additional_options.should == ['--opt']
+ db.mongodump_options .should == ['--opt']

This comment has been minimized.

Show comment Hide comment
@tombruijn

tombruijn Sep 12, 2014

Owner

Unneeded space here

@tombruijn

tombruijn Sep 12, 2014

Owner

Unneeded space here

db.only_collections.should == ['users', 'pirates']
- db.additional_options.should == ['--query', '--foo']
+ db.mongodump_options .should == ['--query', '--foo']

This comment has been minimized.

Show comment Hide comment
@tombruijn

tombruijn Sep 12, 2014

Owner

Unneeded space here

@tombruijn

tombruijn Sep 12, 2014

Owner

Unneeded space here

db.only_collections.should == []
- db.additional_options.should == []
+ db.mongodump_options .should == []

This comment has been minimized.

Show comment Hide comment
@tombruijn

tombruijn Sep 12, 2014

Owner

Unneeded space here

@tombruijn

tombruijn Sep 12, 2014

Owner

Unneeded space here

@tombruijn

This comment has been minimized.

Show comment Hide comment
@tombruijn

tombruijn Sep 12, 2014

Owner

hi @benmccann, thanks for the PR. Sorry for the long wait.

As far as I can see you added another mode (filesystem) to backup with. There's also some refactoring/restructuring. It seems to be backwards compatible, other than the deprecation warning, giving the gem a minor version bump would this be merged in.

Is there anything else I should worry about before merging this in?

Owner

tombruijn commented Sep 12, 2014

hi @benmccann, thanks for the PR. Sorry for the long wait.

As far as I can see you added another mode (filesystem) to backup with. There's also some refactoring/restructuring. It seems to be backwards compatible, other than the deprecation warning, giving the gem a minor version bump would this be merged in.

Is there anything else I should worry about before merging this in?

@benmccann

This comment has been minimized.

Show comment Hide comment
@benmccann

benmccann Sep 12, 2014

Hey, yeah, I wanted to backup this files from the file system directly instead of doing a mongodump since that's more efficient on large DBs. Don't think there's much to worry about with this one.

I appreciate the review. However, I couldn't wait any longer for this to be merged and ended up coding up my own solution instead. If you'd still like to merge it, that'd be awesome since maybe it would help others. I'm afraid I don't have the time at the moment to address any comments though, so hopefully you could address anything that's needed if you're still interested in this PR.

Hey, yeah, I wanted to backup this files from the file system directly instead of doing a mongodump since that's more efficient on large DBs. Don't think there's much to worry about with this one.

I appreciate the review. However, I couldn't wait any longer for this to be merged and ended up coding up my own solution instead. If you'd still like to merge it, that'd be awesome since maybe it would help others. I'm afraid I don't have the time at the moment to address any comments though, so hopefully you could address anything that's needed if you're still interested in this PR.

@tombruijn

This comment has been minimized.

Show comment Hide comment
@tombruijn

tombruijn Sep 13, 2014

Owner

I'll have a closer look at it in the coming weeks. For now I'll leave it open.

Owner

tombruijn commented Sep 13, 2014

I'll have a closer look at it in the coming weeks. For now I'll leave it open.

@chuyik

This comment has been minimized.

Show comment Hide comment
@chuyik

chuyik Jan 5, 2016

Hi any progress?

chuyik commented Jan 5, 2016

Hi any progress?

@tombruijn

This comment has been minimized.

Show comment Hide comment
@tombruijn

tombruijn Jan 9, 2016

Owner

No, I didn't get around to it and I'm currently busy with other things. It would be great if anyone else could pick it up

Owner

tombruijn commented Jan 9, 2016

No, I didn't get around to it and I'm currently busy with other things. It would be great if anyone else could pick it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment