Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add support for backing up MongoDB database files directly #415
referenced this pull request
Mar 8, 2013
hi @benmccann, thanks for the PR. Sorry for the long wait.
As far as I can see you added another mode (filesystem) to backup with. There's also some refactoring/restructuring. It seems to be backwards compatible, other than the deprecation warning, giving the gem a minor version bump would this be merged in.
Is there anything else I should worry about before merging this in?
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Hey, yeah, I wanted to backup this files from the file system directly instead of doing a mongodump since that's more efficient on large DBs. Don't think there's much to worry about with this one.
I appreciate the review. However, I couldn't wait any longer for this to be merged and ended up coding up my own solution instead. If you'd still like to merge it, that'd be awesome since maybe it would help others. I'm afraid I don't have the time at the moment to address any comments though, so hopefully you could address anything that's needed if you're still interested in this PR.