New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail when Fog responds with non-error result #510

Closed
wants to merge 1 commit into
base: v4
from

Conversation

Projects
None yet
1 participant
@joeyates
Contributor

joeyates commented Dec 2, 2013

When calling 'delete_with_multiple_objects', when there are no errors,
Fog can respond with an non-empty DeleteResult array.
Select only error results before deciding whether to fail.

Don't fail when Fog responds with non-error result
When calling 'delete_with_multiple_objects', when there are no errors,
Fog can respond with an non-empty DeleteResult array.
Select only error results before deciding whether to fail.
@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Dec 5, 2013

I thought passing :quiet => true here took care of this? See in fog here
Are you seeing this despite this?

ghost commented Dec 5, 2013

I thought passing :quiet => true here took care of this? See in fog here
Are you seeing this despite this?

@joeyates

This comment has been minimized.

Show comment
Hide comment
@joeyates

joeyates Dec 5, 2013

Contributor

I was getting this with more than 1000 objects.

It looks like this is caused by Fog altering your opts Hash:

data << "<Quiet>true</Quiet>" if options.delete(:quiet)

The second time through, you're re-passing opts, but it's now empty.

I'll open a pull request with Fog.

Maybe, in the meantime as a fix, you could move the definition of opts into the loop.

Contributor

joeyates commented Dec 5, 2013

I was getting this with more than 1000 objects.

It looks like this is caused by Fog altering your opts Hash:

data << "<Quiet>true</Quiet>" if options.delete(:quiet)

The second time through, you're re-passing opts, but it's now empty.

I'll open a pull request with Fog.

Maybe, in the meantime as a fix, you could move the definition of opts into the loop.

ghost pushed a commit that referenced this pull request Dec 6, 2013

@ghost ghost closed this in 5dcf43e Dec 6, 2013

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Dec 6, 2013

@joeyates Thanks, nice catch!

ghost commented Dec 6, 2013

@joeyates Thanks, nice catch!

@joeyates

This comment has been minimized.

Show comment
Hide comment
@joeyates

joeyates Dec 6, 2013

Contributor

Any chance of a backport to version 3?

Contributor

joeyates commented Dec 6, 2013

Any chance of a backport to version 3?

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Dec 6, 2013

It's there, I updated both branches.

ghost commented Dec 6, 2013

It's there, I updated both branches.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment