Patch tar call #92

Merged
merged 1 commit into from Mar 25, 2011

Conversation

Projects
None yet
2 participants
@szimmermann
Contributor

szimmermann commented Mar 23, 2011

Hello Michael!

I changed only one line in your "archive.rb", cause it rose an error on my FreeBSD machines. The installed "tar"-utility (which is distributed with the base system) has a nasty default for output:

(look at the "-f" parameter)

[root@www1 ~]# tar --help
tar(bsdtar): manipulate archive files
First option must be a mode specifier:
  -c Create  -r Add/Replace  -t List  -u Update  -x Extract
Common Options:
  -b #  Use # 512-byte records per I/O block
  -f   Location of archive (default /dev/sa0)
  -v    Verbose
  -w    Interactive
(...)
bsdtar 2.7.0 - libarchive 2.7.0

The correspondenting error:

[root@www1 ~]# tar -c . 1> bla.tar
tar: Failed to open '/dev/sa0'
[root@www1 ~]# tar -c -f bla.tar .          
[root@www1 ~]# 

Hope this finds the way back in your nice piece of software.

Kind regards, Stefan

@szimmermann

This comment has been minimized.

Show comment Hide comment
@szimmermann

szimmermann Mar 23, 2011

Contributor

Ah ... I forgot to say that I tested this on several Linux machines too; every version of tar known by me support the "-f" parm but there may exist versions that won't handle this. This should be reviewed by someone else, who is more in the Linux business. ;-)

Contributor

szimmermann commented Mar 23, 2011

Ah ... I forgot to say that I tested this on several Linux machines too; every version of tar known by me support the "-f" parm but there may exist versions that won't handle this. This should be reviewed by someone else, who is more in the Linux business. ;-)

@mrrooijen

This comment has been minimized.

Show comment Hide comment
@mrrooijen

mrrooijen Mar 23, 2011

Owner

Hey, thanks for this! I actually only tested the whole Backup gem against OSX and Ubuntu. From what I can see the tar utility used with that distro also supports the -f param so i should be able to merge this in soon. Ty!

Owner

mrrooijen commented Mar 23, 2011

Hey, thanks for this! I actually only tested the whole Backup gem against OSX and Ubuntu. From what I can see the tar utility used with that distro also supports the -f param so i should be able to merge this in soon. Ty!

@mrrooijen mrrooijen merged commit 5705e7e into backup:develop Mar 25, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment