Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better code #1

Open
bacloud14 opened this issue Dec 7, 2019 · 5 comments
Open

Better code #1

bacloud14 opened this issue Dec 7, 2019 · 5 comments

Comments

@bacloud14
Copy link
Owner

@bacloud14 bacloud14 commented Dec 7, 2019

I just jumped to JavaScript manipulating Dom and Asyn programming. This is very new to me, I know code is very poorly written. There is only one JS file and one HTML file. All code is concerned.
Task: code review or pass into : https://jshint.com/

@hamczu

This comment has been minimized.

Copy link

@hamczu hamczu commented Dec 12, 2019

just FYI: most of the JS community switched to ESLint

@bacloud14

This comment has been minimized.

Copy link
Owner Author

@bacloud14 bacloud14 commented Dec 14, 2019

It seems to be the same, for a poorly written code, and yes, I agree.

@Marie-Burns22

This comment has been minimized.

Copy link

@Marie-Burns22 Marie-Burns22 commented Jan 8, 2020

Hi, I am a newish developer and looking for my first open source contribution. I looked through the JS file and saw some things I think I can improve. Although I am not sure how to make all the improvements needed, there are some minor things I know how to cleanup. Also, it seems that JS is moving away from using var and instead using let and const. Would changing that be something you are interested in for this project? I'd love to fork, clone, and make a branch to work on. I could do one for the minor things and a different branch for the var/let/const changes. Thanks!

@bacloud14

This comment has been minimized.

Copy link
Owner Author

@bacloud14 bacloud14 commented Jan 8, 2020

Hello Marie,
Oh of course ! I know some of these new Ecmascript 6 new features, but I am not fully aware.
Yes I am very interested, the solution itself is very easy to debug as you might see, just a single JS file with some dependencies, so debugging is easy and direct on the browser. Go for it !
Thanks Marie.

@Marie-Burns22

This comment has been minimized.

Copy link

@Marie-Burns22 Marie-Burns22 commented Jan 9, 2020

Great! I will fork, clone, and make a new branch to work on over the next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.