Better partial support for from(Node)Callback (pull request)
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing values from other streams into `fromCallback` and `fromNodeCallback` is pretty cumbersome. This patch hacks `fromNodeCallback` so that it can take any number of primitive values and `Observable`s (`EventStream` and `Property` objects, for instance). It will call its callback once it has all the values from all the sources.
|
Great work! Merging. Now, it would be really really great if someone blogged about using Bacon.js on the server-side, using these new lifted callbacks :) |
raimohanska
added a commit
that referenced
this pull request
Apr 3, 2013
Better partial support for `from(Node)Callback` (pull request). Close #133.
|
Totally getitng the "nudge-nudge-wink-wink" :) Post will be coming up this weekend, if all goes as planned. |
|
I wish there was a Like button in Github comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #133