New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better partial support for `from(Node)Callback` (pull request) #143

Merged
merged 10 commits into from Apr 3, 2013

Conversation

Projects
None yet
2 participants
@abesto
Contributor

abesto commented Apr 3, 2013

As discussed in #133

abesto added some commits Mar 28, 2013

Smarten up `fromNodeCallback` (see description)
Passing values from other streams into `fromCallback` and
`fromNodeCallback` is pretty cumbersome. This patch hacks
`fromNodeCallback` so that it can take any number of primitive values
and `Observable`s (`EventStream` and `Property` objects, for instance).
It will call its callback once it has all the values from all the
sources.
@raimohanska

This comment has been minimized.

Contributor

raimohanska commented Apr 3, 2013

Great work! Merging.

Now, it would be really really great if someone blogged about using Bacon.js on the server-side, using these new lifted callbacks :)

raimohanska added a commit that referenced this pull request Apr 3, 2013

Merge pull request #143 from abesto/smart-from-callback
Better partial support for `from(Node)Callback` (pull request). Close #133.

@raimohanska raimohanska merged commit 19d1f56 into baconjs:master Apr 3, 2013

1 check passed

default The Travis build passed
Details
@abesto

This comment has been minimized.

Contributor

abesto commented Apr 3, 2013

Totally getitng the "nudge-nudge-wink-wink" :) Post will be coming up this weekend, if all goes as planned.

@raimohanska

This comment has been minimized.

Contributor

raimohanska commented Apr 3, 2013

I wish there was a Like button in Github comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment