Follow-up: remove unused get_commands cwd parameter#20
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the unused cwd parameter from the get_commands function in src/commands.py. The reviewer suggests converting the remaining boolean parameters into keyword-only arguments to improve code readability and prevent potential misuse from positional arguments.
badMade
merged commit fb05d80
into
performance-optimize-get-command-1051592804651335151
badMade
deleted the
badmade/github-mention-optimize-get_command-with-o1-lookup-dictio-r55w0j
branch
Owner
Author
|
@copilot code review |
Owner
Author
|
@claude code review |
There was a problem hiding this comment.
Pull request overview
Removes an unused cwd parameter from get_commands to simplify the API and eliminate confusion about an argument that had no effect.
Changes:
- Drop
cwd: str | None = Nonefromget_commandsinsrc/commands.py. - Keep existing command filtering behavior and return type unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cwdparameter fromget_commandsto simplify the function signature and avoid confusion.Description
cwd: str | None = Noneargument fromget_commandsinsrc/commands.py, preserving existing filtering logic and return type.Testing
pytest -qin a plain environment which failed due to import path setup (ModuleNotFoundError: No module named 'src').PYTHONPATH=. pytest -qand all tests passed (22 passed).Codex Task