Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update browser dependency (and a few others) #3

Merged
merged 2 commits into from Oct 23, 2022
Merged

Update browser dependency (and a few others) #3

merged 2 commits into from Oct 23, 2022

Conversation

evert
Copy link
Contributor

@evert evert commented Oct 23, 2022

No description provided.

@evert evert requested a review from mattbishop October 23, 2022 02:01
@evert evert self-assigned this Oct 23, 2022
@evert evert enabled auto-merge October 23, 2022 02:01
@mattbishop
Copy link
Collaborator

It's just the package lock file. Did you want to put in a package.json too?

@evert
Copy link
Contributor Author

evert commented Oct 23, 2022

@mattbishop This PR is just the outcome of the default behavior of npm update, which updates all packages to the latest version, in range of what's specified in package.json.

I have no qualms updating package.json though =)

mattbishop
mattbishop approved these changes Oct 23, 2022
View reviewed changes
Copy link
Collaborator

@mattbishop mattbishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I don't like to use npm actually, I prefer yarn, so that's why I'm looking to the package.json file for version updates.

@evert evert merged commit 4b6d167 into main Oct 23, 2022
@evert evert deleted the update-browser branch October 23, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattbishop mattbishop mattbishop approved these changes

Assignees

@evert evert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evert @mattbishop