Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wireframes #46

Merged
merged 11 commits into from Oct 26, 2022
Merged

Add wireframes #46

merged 11 commits into from Oct 26, 2022

Conversation

ikbensiep
Copy link
Contributor

@ikbensiep ikbensiep commented Oct 18, 2022

Add wireframes.svg file v1, includes pdf preview.

It's not 100% complete but gives a pretty good picture of the proposal.
This is a lot like what I presented during last demo day. I think becky and syed both weren't there to see it? 🤔

Multipage pdf export isn't perfect yet, use a vector editor (inkscape) to view the entire file.

@ikbensiep ikbensiep added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Oct 18, 2022
Copy link
Contributor

@syedfkabir syedfkabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but before approving I assume we'll have a meeting first.

@BeckyPollard
Copy link
Contributor

Pre-meeting notes: THESE ARE FREAKIN' SICK

Copy link
Contributor

@BeckyPollard BeckyPollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only nit is that these files should live in a /resources folder to keep things tidy, but after that merge this in! These are a great asset and really helps the project take form!

@BeckyPollard BeckyPollard mentioned this pull request Oct 18, 2022
11 tasks
@ikbensiep ikbensiep merged commit 0ca8f34 into main Oct 26, 2022
@ikbensiep ikbensiep deleted the sh/wireframes branch October 26, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants