Update Entry Submit to point at existing endpoint #48 #49
Conversation
| @@ -48,7 +48,7 @@ export function PersonWeeklyEntries(props: Props) { | |||
| {[0, 1, 2, 3, 4, 5, 6].map( val => | |||
| <EntryDay | |||
| date={currentDate.plus({'days': val})} | |||
| resource={resourceState.follow('search-sheet', { year: currentDate.year, weekNum: currentDate.weekNumber })} | |||
| resource={resourceState.follow('entry-collection')} | |||
There was a problem hiding this comment.
I have a hunch this change means that entries are no longer filtered by weeks, so every week shows all entries in the system.
There was a problem hiding this comment.
made some changes to address this!
tested and ready to review
There was a problem hiding this comment.
Just to clarify this more, we must continue to use the existing search-sheet resource for this because if we don't, you are loading in every time entry ever made.
We need to continue to filter by week. The search-sheet link was added so we can do that.
There was a problem hiding this comment.
So even though visually this might do the right thing. If a user has thousands of entries, this change would load all of them in and we don't want that.
There was a problem hiding this comment.
Might be in the same spirit as Evert's feedback, but on testing this, seems we've lost the time entries rendering. After submit the entry just vanishes. DB updates though which is rad.
Visual example
Above: current state as of review.
Below:mainbranch with time entries rendering.
|
PR Closed due to: #49 (comment) |
Resolves #48
Changes
/pages/people/person/Timesheet.tsxto now follow 'entry-collection'EntryDayItemNewcomponent to have the parent componentpostFollowinstead ofpostNotes for PR
Screenshots
Submitting without a selected project
Minimized screen showing no selected project (even though there is)