Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.13 Plugin No Longer Runs #30

Closed
Tom-Archer opened this issue Aug 9, 2018 · 5 comments
Closed

0.2.13 Plugin No Longer Runs #30

Tom-Archer opened this issue Aug 9, 2018 · 5 comments

Comments

@Tom-Archer
Copy link

Tom-Archer commented Aug 9, 2018

The zip file, "svg2shenzhen-extension.zip" that makes up release 0.2.13 contains the following code in "export.py":

    def processExportLayer(self):
        insertion_date = dateutil.parser.parse('2018-07-28 14:25:30')
        time_between_insertion = datetime.now() - insertion_date

        if (time_between_insertion.days>7):
            return

This now means the plugin doesn't run. Was this planned obsolescence?

@Tom-Archer
Copy link
Author

This also places a dependency on the "dateutil" package, which isn't imported at the top of the file, nor is it installed by default as part of a Python installation. Took me a bit of hacking to get this script to actually run.

@kasbah
Copy link
Collaborator

kasbah commented Aug 12, 2018

Can confirm that's what's in the zip. I have been using the git version so never checked the zip. @badgeek, what the hell!? I wasn't aware of this! Pretty easy to remove but, just, why? There needs to be a release with a fix ASAP and an explanation!

Here is a fixed zip in the meantime: https://cloud.monostable.co.uk/svg2shenzhen-fb80c3a.zip.
Someone can verify that this is a straight up zip of the Inkscape folder at state of the code at the fb80c3a commit for reassurance.

There are compiled binaries in the source tree though. Are those modified from the source as well @badgeek? Will they do some stupid shit too!?

@kasbah
Copy link
Collaborator

kasbah commented Aug 12, 2018

I just realised I have the ability to make releases so I made https://github.com/badgeek/svg2shenzhen/releases/tag/v0.2.14. I deleted the zip for v0.2.13. I still need an explanation for this nonsense though.

@badgeek
Copy link
Owner

badgeek commented Aug 12, 2018 via email

@kasbah
Copy link
Collaborator

kasbah commented Aug 20, 2018

Hey, @badgeek and I have been in touch privately. There has been a lot of personal drama in their life unrelated to this and it's not the right time to press for an explanation about this weird timeout code that never even worked. @badgeek did apologize for it and hopefully should be back on here soon, when they find time, helping out with svg2shenzhen.

With the release of 0.2.14 the code is removed so I am going to mark this issue as resolved.

When I find time I will re-organize the C++ code for our bitmap2component fork and re-compile the binaries with added features but I have no good reason to be suspicious of the current binary release.

@kasbah kasbah closed this as completed Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants