Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for base class overrides #2060

Closed
chris48s opened this issue Sep 6, 2018 · 1 comment
Closed

Add more tests for base class overrides #2060

chris48s opened this issue Sep 6, 2018 · 1 comment
Labels
developer-experience Dev tooling, test framework, and CI good first issue New contributors, join in!

Comments

@chris48s
Copy link
Member

chris48s commented Sep 6, 2018

It would be great to have more tests for all of these overrides:

shields/services/base.js

Lines 240 to 249 in a265cab

const {
style,
label: overrideLabel,
logo: overrideLogo,
logoColor: overrideLogoColor,
logoWidth: overrideLogoWidth,
link: overrideLink,
colorA: overrideColorA,
colorB: overrideColorB,
} = overrides

At the moment we only have 2:

describe('Overrides', function() {
it('overrides the label', function() {
const badgeData = DummyService._makeBadgeData(
{ label: 'purr count' },
{ label: 'purrs' }
)
expect(badgeData.text).to.deep.equal(['purr count', 'n/a'])
})
it('overrides the color', function() {
const badgeData = DummyService._makeBadgeData(
{ colorB: '10ADED' },
{ color: 'red' }
)
expect(badgeData.colorB).to.equal('#10ADED')
})
})

@chris48s chris48s added good first issue New contributors, join in! developer-experience Dev tooling, test framework, and CI labels Sep 6, 2018
@platan platan added hacktoberfest Same as "good first issue" and removed hacktoberfest Same as "good first issue" labels Sep 30, 2018
@platan platan removed hacktoberfest Same as "good first issue" labels Nov 1, 2018
@calebcartwright
Copy link
Member

Is this still up for grabs? If so I'll give it a try as it looks simple enough (famous last words 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI good first issue New contributors, join in!
Projects
None yet
Development

No branches or pull requests

3 participants