Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub project badge for Hacktoberfest [GithubHacktoberfest] #4109

Merged
merged 15 commits into from Oct 3, 2019

Conversation

@paulmelnikow
Copy link
Member

commented Oct 2, 2019

Something I've wanted to offer is a nice badge for Hacktoberfest, which projects can use to advertise their participation, encourage contributions, and celebrate new contributions. There was some discussion about this at #1519 (comment) and a little bit of chat in Discord today.

Here's a proposal! Would be really curious for comments!

By default this counts open issues labeled hacktoberfest but you can pick a different label if you want. By default it counts all PRs merged in October but you can filter that with a label if you want.

This is hard-coded for Hacktoberfest 2019. At some point if people like the badge, we'll want to generalize it, though I think we could wait and do that sometime next year.

Alternatively we could include 2019 in the badge URL, which would make it clear that projects are participating in a given year (as opposed to some past year) and also to display stats from previous years.

@shields-cd shields-cd temporarily deployed to shields-staging-pr-4109 Oct 2, 2019 Inactive
@shields-ci

This comment has been minimized.

Copy link

commented Oct 2, 2019

Messages
📖 Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 7469eda

@paulmelnikow paulmelnikow changed the title Add a GitHub project badge for [Hacktoberfest] Add a GitHub project badge for Hacktoberfest [GithubHacktoberfest] Oct 2, 2019
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-4109 Oct 2, 2019 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-4109 Oct 2, 2019 Inactive
@paulmelnikow

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

As I think about this more, I'm thinking the route should be /github/hacktoberfest/2019/:user/:repo. That way when you see the badge you know it's fresh, and the badges can be used later to show stats from the previous event.

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-4109 Oct 2, 2019 Inactive
@paulmelnikow paulmelnikow marked this pull request as ready for review Oct 2, 2019
paulmelnikow and others added 2 commits Oct 2, 2019
Co-Authored-By: Matt (IPv4) Cowley <me@mattcowley.co.uk>
Co-Authored-By: Matt (IPv4) Cowley <me@mattcowley.co.uk>
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-4109 Oct 2, 2019 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-4109 Oct 2, 2019 Inactive
@paulmelnikow

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

Thanks for the comments @MattIPv4!

@calebcartwright

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

I love this idea!

daysLeft > 0 ? `${daysLeft} day${daysLeft > 1 ? 's' : ''} left` : '',
]
.filter(Boolean)
.join(', ') || 'is done!'

This comment has been minimized.

Copy link
@calebcartwright
Copy link
Member Author

left a comment

.

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-4109 Oct 2, 2019 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-4109 Oct 2, 2019 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-4109 Oct 2, 2019 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-4109 Oct 2, 2019 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-4109 Oct 2, 2019 Inactive
Copy link
Member

left a comment

🚀

@paulmelnikow paulmelnikow merged commit 76cb943 into master Oct 3, 2019
14 of 17 checks passed
14 of 17 checks passed
Header rules - shields-docs No header rules processed
Details
Pages changed - shields-docs 70 new files uploaded
Details
Redirect rules - shields-docs No redirect rules processed
Details
Gitpod Open an online workspace in Gitpod
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - shields-docs No mixed content detected
Details
ci/circleci: danger Your tests passed on CircleCI!
Details
ci/circleci: e2e Your tests passed on CircleCI!
Details
ci/circleci: frontend Your tests passed on CircleCI!
Details
ci/circleci: integration@node-latest Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: main@node-latest Your tests passed on CircleCI!
Details
ci/circleci: package Your tests passed on CircleCI!
Details
ci/circleci: services Your tests passed on CircleCI!
Details
ci/circleci: services@node-latest Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
netlify/shields-docs/deploy-preview Deploy preview ready!
Details
@paulmelnikow paulmelnikow deleted the hacktoberfest-badge branch Oct 3, 2019
@shields-deployment

This comment has been minimized.

Copy link

commented Oct 3, 2019

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.