New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub issue-nonpr badge #839
Conversation
Thanks for this contribution! Look great and would love to get it merged. Sorry for the delay! Could I ask you to add an entry to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please rebase and update try.html
? Thanks!
f1d3152
to
07d788e
Compare
07d788e
to
614ef4a
Compare
Rebased, fixed the conflict and added it to What do you think about using this instead of the normal issue counter? I believe it's probably what people expect from the normal |
I tend to agree. However issues and pull requests are combined into a combined search interface in the UI, so it's not a total surprise, and in the discussion at #420 @espadrine said he thought the current behavior should be preserved for @espadrine That was a couple years ago… do you still feel that way? Perhaps we could update the text for that badge, to say "issues and pull requests"? That change would make it clear what they're getting, and could encourage users to consider the alternatives. |
@espadrine Could I ask you to respond to this question? ^^ Would love to get this merged. |
The current state of things seems to have both the issues badge and the pull requests badge showing the sum of issues and pull requests. I would argue that not fixing the current badges would violate the shields specification because the number does not represent what is semantically indicated on the left-hand side. Adding badges today, if I see the number is in correct, but I want the badge, I would still add it trusting the bug to be fixed and not expect to need to change it later. However, if the current issues and PR badges are not to be fixed, I would say the text should be changed to says "issues and pull requests" so that it accurately represents what is displayed and consumers might notice and change it to the "fixed" issues badge if they want only issues. |
Merged via #1020. |
This adds a variant of the GitHub issue badge which only counts real issues and skips PRs. Issues normally counting pull requests as well doesn't seem intuitive, but I didn't want to change the default one to keep backwards compatibility. New syntax is:
Ref. #420