Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaboration #37

Merged
merged 19 commits into from Mar 6, 2020
Merged

Collaboration #37

merged 19 commits into from Mar 6, 2020

Conversation

@annejan
Copy link
Member

annejan commented Mar 4, 2020

Fixes #36

annejan added 7 commits Mar 3, 2020
@annejan annejan added the enhancement label Mar 4, 2020
@annejan annejan self-assigned this Mar 4, 2020
@annejan

This comment has been minimized.

Copy link
Member Author

annejan commented Mar 4, 2020

Codecov Report

Merging #37 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   82.22%   82.08%   -0.14%     
==========================================
  Files          56       56              
  Lines        1018     1044      +26     
==========================================
+ Hits          837      857      +20     
- Misses        181      187       +6     
Impacted Files Coverage Δ
app/Models/File.php 100.00% <0.00%> (+10.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae675c5...901f0d8. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 4, 2020

Codecov Report

Merging #37 into master will increase coverage by 11.59%.
The diff coverage is 93.13%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #37       +/-   ##
===========================================
+ Coverage   82.22%   93.81%   +11.59%     
===========================================
  Files          56       56               
  Lines        1018     1083       +65     
===========================================
+ Hits          837     1016      +179     
+ Misses        181       67      -114
Impacted Files Coverage Δ
app/Http/Middleware/VerifyCsrfToken.php 100% <ø> (+25%) ⬆️
app/Http/Controllers/Auth/TwoFAController.php 100% <ø> (+100%) ⬆️
app/Http/Controllers/WeatherController.php 100% <100%> (+100%) ⬆️
app/Policies/ProjectPolicy.php 100% <100%> (ø) ⬆️
app/Policies/UserPolicy.php 100% <100%> (ø) ⬆️
app/Policies/FilePolicy.php 100% <100%> (ø) ⬆️
app/Http/Controllers/PublicController.php 100% <100%> (+2.6%) ⬆️
app/Http/Controllers/VotesController.php 100% <100%> (+23.52%) ⬆️
app/Models/Project.php 100% <100%> (ø) ⬆️
app/Http/Controllers/Auth/RegisterController.php 100% <100%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae675c5...f215b91. Read the comment docs.

annejan added 12 commits Mar 4, 2020
@annejan annejan merged commit 876848d into master Mar 6, 2020
16 of 19 checks passed
16 of 19 checks passed
laravel-tests (7.2)
Details
laravel-tests (7.2)
Details
laravel-tests (7.3)
Details
laravel-tests (7.3)
Details
laravel-tests (7.4)
Details
laravel-tests (7.4)
Details
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
Scrutinizer Created
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
codecov/patch 93.13% of diff hit (target 82.22%)
Details
codecov/project 93.81% (+11.59%) compared to ae675c5
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk (annejan) All security tests have passed
Details
workflow Workflow: workflow
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.