Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is Status used for? #30

Open
badlydrawnrob opened this issue Mar 8, 2024 · 0 comments
Open

What is Status used for? #30

badlydrawnrob opened this issue Mar 8, 2024 · 0 comments

Comments

@badlydrawnrob
Copy link
Owner

badlydrawnrob commented Mar 8, 2024

There's a lot going on in this program, and we're using Status type a lot. I was going to use Status type for a Random script but thought better of it.

  1. A Random value is always going to return something (if it's set up properly)
  2. In this file I'm calling a function that cycles through model.status — in fact model.status is getting checked in 3 or more locations
  3. It's a little confusing to me why we're having to use selectedUrl and casing on the Status again.
    • The only reason I can think that GotRandomPhoto photo and ClickedPhoto url require to call selectedUrl function (which cases on the Status) is that we need to check if the photos are in an unloaded state.
    • But why couldn't we make the images unclickable or something, rather than casing on it in too many places?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant